first command run for zsh does not have the right status

[meganrogge]

[meganrogge]

updated Insider's and the problem remains

[Tyriar]

@meganrogge I think this is the same as #143766? We will need to always send the exit code and have it get evaluated on the renderer against the extracted command name to fix these problems.

[meganrogge]

sometimes reproduces on mac

[Tyriar]

@meganrogge you can check if this is the same issue (due to this code) by running a command a few times and then when history is run if it's a single entry or multiple in the output.

[meganrogge]

interesting to me that it allows repro on linux/WSL and does so inconsistently on mac. here's linux:

[Tyriar]

K, let's try understand this a little better then, that shouldn't happen as the initial history id is 0:

vscode/src/vs/workbench/contrib/terminal/browser/media/shellIntegration-rc.zsh

Line 25 in 5357dcf

__vsc_last_history_id=0

[meganrogge]

Oh I figured out when it reproes on mac - if you run the same command in a different terminal, then the second and beyond ones don't have an exit code

[meganrogge]

Running the command again in the terminal where you first ran the command works every time and does not repro on mac.

So mac steps are:

1. Run echo hi in terminal 1 -> ✅
2. Run echo hi again in terminal 1 -> ✅
3. Run echo hi in terminal 2 -> ❌

Linux:

1. Create a terminal and run any command -> ❌ placeholder decoration shown for the first one regardless of exit code

[meganrogge]

It would be nice to fix this since zsh is the default shell used

[Tyriar]

Think I see the problem, PR incoming.