Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"size limit" link in warning does not open setting in Settings GUI #151364

Closed
tanhakabir opened this issue Jun 2, 2022 · 3 comments · Fixed by #152896
Closed

"size limit" link in warning does not open setting in Settings GUI #151364

tanhakabir opened this issue Jun 2, 2022 · 3 comments · Fixed by #152896
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
October 2022

Comments

@tanhakabir
Copy link
Contributor

While verifying microsoft/vscode-jupyter#10345 I noticed that if I click on the Output exceeds the size limit. Open the full output data in a text editor warning I'm not taken to the size limit setting which I would've expected to be taken to.

Recording 2022-06-02 at 15 30 36

Environment data

Version: 1.68.0-insider (Universal)
Commit: 15253f1
Date: 2022-06-02T05:16:30.515Z
Electron: 17.4.6
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Darwin x64 21.5.0
Jupyter Extension version (available under the Extensions sidebar): v2022.5.1001552309
Python Extension version (available under the Extensions sidebar): v2022.7.11521008
@tanhakabir tanhakabir added the bug Issue identified by VS Code Team member as probable bug label Jun 2, 2022
@greazer greazer added papercut 🩸 A particularly annoying issue impacting someone on the team and removed triage-needed papercut 🩸 A particularly annoying issue impacting someone on the team labels Jun 6, 2022
@greazer greazer transferred this issue from microsoft/vscode-jupyter Jun 6, 2022
@greazer
Copy link
Contributor

greazer commented Jun 6, 2022

This link is specified in core code.

rzhao271 added a commit that referenced this issue Jun 22, 2022
@rzhao271
Fix command encoding. Fixes #151364
f12237b
@rzhao271 rzhao271 mentioned this issue Jun 22, 2022
Merged
rzhao271 added a commit that referenced this issue Jun 22, 2022
@rzhao271
Fix command encoding. Fixes #151364 (#152896)
5f0a388
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 22, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the June 2022 milestone Jun 22, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 23, 2022
@rzhao271
Copy link
Contributor

The issue doesn't seem to be fixed in the latest insiders. Reopening

@rzhao271 rzhao271 reopened this Jun 29, 2022
@rzhao271 rzhao271 modified the milestones: June 2022, July 2022 Jun 29, 2022
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jun 29, 2022
@rzhao271 rzhao271 modified the milestones: July 2022, August 2022 Jul 22, 2022
@rzhao271 rzhao271 modified the milestones: August 2022, September 2022 Aug 23, 2022
@rzhao271 rzhao271 modified the milestones: September 2022, October 2022 Sep 26, 2022
@rzhao271
Copy link
Contributor

The issue is now fixed for me in the latest Insiders, at least on Windows 11.

@andreamah andreamah added the verified Verification succeeded label Oct 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
October 2022
Development

Successfully merging a pull request may close this issue.

Fix command encoding. Fixes #151364 microsoft/vscode
6 participants
@IanMatthewHuff @rzhao271 @greazer @tanhakabir @andreamah @VSCodeTriageBot