Context menu for comment threads

[laurentlb]

From @alexr00 (in #150824):

Finally, for comments it might be nice to have all these actions in a context menu on the whole comment peek view. I don't think I'm the only one who will right click on things to see if there are some actions I don't know about.

I think that's a simple feature to add:

1. Add a 3-dot menu on the comment thread title (at the right of other contributed icons)
2. Support right-clicking on the comment thread title

The combination of 3-dot + right-click already exists in other parts of vscode and would improve the experience on wide screens.

This would also help us rely less on icons. New users are often confused with all the icons. Plus, there are multiple features we didn't expose precisely because they cannot be explained with an icon.

cc @hermannloose

[alexr00]

Add a 3-dot menu on the comment thread title (at the right of other contributed icons)

This one may actually be possible for extensions to do with submenus. I'll double check.

[alexr00]

Optimistically adding for June, but will likely end up moving to July.

[alexr00]

Menu proposal (name will likely change):

		"menus": {
			"comments/commentThread/widget/context": [

			]
		}

We already have comments/commentThread/context so we can't use that.

The current proposal shows the same context menu when you right click anywhere in the comment thread widget (title, individual comment, etc.) and passes the comment thread object to the command that's executed. @laurentlb, would you expect to have different context menus depending on where the right click happened?

[laurentlb]

That sounds reasonable.

It's possible that someone would want a separate menu when clicking on a specific comment (this could be added later if needed).
So maybe don't show any menu when clicking on an individual comment?

[alexr00]

I got some more feedback on the initial proposal. Changes include:

• We now have 2 context menus: 1 for the thread title and 1 for individual comments
• Menu name has changed
  • comments/commentThread/title/context
  • comments/commentThread/comment/context

For a full example of how to these menus can be used, you can see microsoft/vscode-pull-request-github#3835

[sergei-dyshel]

@alexr00
Can you please explain how comments/commentThread/title/context is supposed to be used? I've installed pre-release version v0.51.2022092909 of Github extension, which apparently includes Try out the thread context menu proposal PR and it has the following menu entries:

			"comments/commentThread/title/context": [
				{
					"command": "pr.resolveReviewThread",
					"group": "inline@3",
					"when": "commentController =~ /^github-(browse|review)/ && commentThread == canResolve"
				},
				{
					"command": "pr.unresolveReviewThread",
					"group": "inline@3",
					"when": "commentController =~ /^github-(browse|review)/ && commentThread == canUnresolve"
				}
			],
			"comments/commentThread/comment/context": [
				{
					"command": "pr.resolveReviewThread",
					"group": "inline@3",
					"when": "commentController =~ /^github-(browse|review)/ && commentThread == canResolve"
				},
				{
					"command": "pr.unresolveReviewThread",
					"group": "inline@3",
					"when": "commentController =~ /^github-(browse|review)/ && commentThread == canUnresolve"
				}
			],

However when I look at comment thread in vscode, I only see

, e.g. it shows button that corresponds to comments/commentThread/comment/context, but not comments/commentThread/title/context.

Using VScode 1.71 of course

[alexr00]

@sergei-dyshel thanks for trying this out! It's a right click context menu, so there's no UI for it in the comment widget itself. You can access the menu by right clicking in the title part of the widget and the body part of the widget, respectively.

[sergei-dyshel]

Ohh, missed that somehow. I was looking for some "big blue button " in the title section. Thanks for clarification :)

[alexr00]

If anyone wants to use this API in an extension please comment so that I can gauge whether this is worth finalizing.