Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated + selection = bad contrast #152070

Closed
isidorn opened this issue Jun 14, 2022 · 1 comment · Fixed by #152093
Closed

Deprecated + selection = bad contrast #152070

isidorn opened this issue Jun 14, 2022 · 1 comment · Fixed by #152093
Assignees
@sandy081 @daviddossett
Labels
extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders
Milestone
June 2022

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 14, 2022

  1. Light theme. Extensions view. Search for "Rust"
  2. Click on the first result -> notice selection + deprecation transparency make for a bad contrast:

Screenshot 2022-06-14 at 16 27 48
@isidorn isidorn added the extensions Issues concerning extensions label Jun 14, 2022
daviddossett added a commit that referenced this issue Jun 14, 2022
@daviddossett
Fix #152070
f8754ed
@daviddossett daviddossett mentioned this issue Jun 14, 2022
Merged
daviddossett added a commit that referenced this issue Jun 14, 2022
@daviddossett
Fix #152070 (#152093)
731de36
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 14, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the June 2022 milestone Jun 14, 2022
@isidorn
Copy link
Contributor Author

isidorn commented Jun 14, 2022

Thanks @daviddossett 👏

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

@daviddossett daviddossett

Labels
extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Fix #152070 microsoft/vscode
4 participants
@isidorn @sandy081 @daviddossett @VSCodeTriageBot