Should "executing task" be localized?

[Tyriar]

I noticed some task messages weren't localized:

vscode/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts

Lines 1113 to 1117 in 742cea8

	if (needsFolderQualification && workspaceFolder) {
	shellLaunchConfig.initialText = `\x1b[1m> Executing task in folder ${workspaceFolder.name}: ${commandLine} <\x1b[0m\n`;
	} else {
	shellLaunchConfig.initialText = `\x1b[0m\n\n\r\x1b[7m * \x1b[0;44;37m Executing task: ${commandLine} \x1b[0m\n`;
	}

vscode/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts

Lines 1145 to 1149 in 742cea8

	if (needsFolderQualification && workspaceFolder) {
	shellLaunchConfig.initialText = `\x1b[1m> Executing task in folder ${workspaceFolder.name}: ${shellLaunchConfig.executable} ${getArgsToEcho(shellLaunchConfig.args)} <\x1b[0m\n`;
	} else {
	shellLaunchConfig.initialText = `\x1b[1m> Executing task: ${shellLaunchConfig.executable} ${getArgsToEcho(shellLaunchConfig.args)} <\x1b[0m\n`;
	}

vscode/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts

Line 1248 in 742cea8

initialText: task.command.presentation && task.command.presentation.echo ? `\x1b[1m> Executing task: ${task._label} <\x1b[0m\n` : undefined,

Terminal support for unicode is pretty great now so if we have issues with other languages here we should fix them.

[alexr00]

Seems like a good idea. Changing these would only be an issue if we have extensions that are reading terminal output and looking for these strings.

[Tyriar]

That's a proposed api that will probably never get finalized, I doubt the few that use this would be checking for task messages like that.