Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single search match not handled correctly when a command uses cd <path> && #152275

Closed
Tyriar opened this issue Jun 16, 2022 · 2 comments · Fixed by #153141
Closed

Single search match not handled correctly when a command uses cd <path> && #152275

Tyriar opened this issue Jun 16, 2022 · 2 comments · Fixed by #153141
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 16, 2022

Expected behavior here is that activating the link should open the file without the quickpick because there is only a single match, but even if there were 2 matches the end segment matches exactly so it should be covered if the other match does not end with the end of the path. Might be caused by the line/col number or separators?

image

This ends up happening regardless of whether shell integration is disabled when yarn smoketest is run in vscode because the cwd of the inner process is test/smoke via the cd here:

"smoketest": "node build/lib/preLaunch.js && cd test/smoke && yarn compile && node test/index.js",

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-links labels Jun 16, 2022
@Tyriar Tyriar added this to the June 2022 milestone Jun 16, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Jun 24, 2022

The cd and line/col doesn't matter here, just any link that starts in a sub dir:

image

Since the path matches the end of the match exactly, it should open it and not show the quick pick.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 24, 2022

This is shell integration's confidence in the cwd forcing the searched path to be relative to the cwd:

image

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 24, 2022
@connor4312 connor4312 added the verified Verification succeeded label Jul 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants