Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable shell integration reporting for tasks #152387

Closed
meganrogge opened this issue Jun 16, 2022 · 1 comment · Fixed by #153139
Closed

enable shell integration reporting for tasks #152387

meganrogge opened this issue Jun 16, 2022 · 1 comment · Fixed by #153139
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders on-testplan tasks Task system issues terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
June 2022

Comments

@meganrogge
Copy link
Contributor

vscode/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

Line 228 in cb5fa75

this._disableShellIntegrationReporting = this.shellLaunchConfig.isFeatureTerminal || this.shellLaunchConfig.hideFromUser || this.shellLaunchConfig.executable === undefined;

@meganrogge meganrogge self-assigned this Jun 16, 2022
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug tasks Task system issues terminal-shell-integration Shell integration, command decorations, etc. labels Jun 16, 2022
@meganrogge meganrogge modified the milestones: July 2022, June 2022 Jun 16, 2022
meganrogge added a commit that referenced this issue Jun 24, 2022
@meganrogge
fix #152387
89164fc 
fix #152753
@meganrogge meganrogge mentioned this issue Jun 24, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 24, 2022
@joyceerhl joyceerhl added the verification-steps-needed Steps to verify are needed for verification label Jun 30, 2022
@meganrogge
Copy link
Contributor Author

@Tyriar a code review here would be helpful

@meganrogge meganrogge removed the verification-steps-needed Steps to verify are needed for verification label Jun 30, 2022
@Tyriar Tyriar added the verified Verification succeeded label Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders on-testplan tasks Task system issues terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

disable shell integration telemetry improvements microsoft/vscode
4 participants
@Tyriar @meganrogge @joyceerhl @VSCodeTriageBot