Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: Letter clipping #152436

Closed
joaomoreno opened this issue Jun 17, 2022 · 2 comments · Fixed by #152486
Closed

Terminal: Letter clipping #152436

joaomoreno opened this issue Jun 17, 2022 · 2 comments · Fixed by #152486
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone
June 2022

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jun 17, 2022 •
edited

Notice the git words in the following screenshot:

image

Does not reproduce in ca8a837, from 3 days ago.

I'm on Windows, using CaskaydiaCove Nerd Font as my font, default size, no zoom.
@Tyriar Tyriar mentioned this issue Jun 17, 2022
Closed
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal-rendering important Issue identified as high-priority labels Jun 17, 2022
@Tyriar Tyriar added this to the June 2022 milestone Jun 17, 2022
@Tyriar
Copy link
Member

Tyriar commented Jun 17, 2022

Caused by #152347

@Tyriar
Copy link
Member

Tyriar commented Jun 17, 2022

xtermjs/xterm.js#3866

@Tyriar Tyriar added upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Jun 17, 2022
Tyriar added a commit that referenced this issue Jun 17, 2022
@Tyriar
xterm-addon-webgl@0.12.0-beta.39
1ed2687 
Fixes #152436
@Tyriar Tyriar mentioned this issue Jun 17, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 17, 2022
@Tyriar Tyriar mentioned this issue Jun 20, 2022
Closed
@mjbvz mjbvz added the verified Verification succeeded label Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
xterm-addon-webgl@0.12.0-beta.39
e13f5e9 
Fixes microsoft#152436
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

xterm-addon-webgl@0.12.0-beta.39 microsoft/vscode
5 participants
@joaomoreno @Tyriar @mjbvz @meganrogge @VSCodeTriageBot