Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command to launch a specific tile in getting started for a particular extension is not working #152598

Closed
karrtikr opened this issue Jun 19, 2022 · 8 comments · Fixed by #153025
Closed
Assignees
Labels
feature-request Request for new features or functionality getting-started insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@karrtikr
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.68.1 (user setup)
OS: Windows_NT x64 10.0.22518

Steps to Reproduce:

  1. Here's a command link of jupyter opening a python walktrhough https://github.com/microsoft/vscode-jupyter/blob/main/package.json#L135, which does not open the mentioned tile.

This can also be observed when executing the command directly:

vscode.commands.executeCommand(
    'workbench.action.openWalkthrough',
    { category: 'ms-python.python#pythonWelcome', step: 'ms-python.python#python.installPythonWin' },
    true,
);

Here're the instructions being used to call the command: #119725 (comment)

cc/ @lramos15

@karrtikr karrtikr changed the title Command to launch a specific tile in getting started is not working Command to launch a specific tile in getting started for a particular extension is not working Jun 19, 2022
@lramos15 lramos15 assigned lramos15 and unassigned mjbvz Jun 20, 2022
@lramos15 lramos15 added bug Issue identified by VS Code Team member as probable bug getting-started and removed triage-needed labels Jun 20, 2022
@karrtikr
Copy link
Contributor Author

Instead of opening a new tab with the tile, it would be great if we can reveal the tile in focus.

@lramos15
Copy link
Member

@karrtikr After investigating this what actually appears to happen is that the step Ids have changed to be scoped to the category. So for Jupyter you need
ms-python.python#pythonDataScienceWelcome#python.createNewNotebook instead of ms-python.python#python.createNewNotebook. This seems like a good change to me but the lack of documentation (as is the case with commands) can be confusing. Does this solve your problem :)?

@karrtikr
Copy link
Contributor Author

Thanks so much for looking at this quickly. It does solve the basic issue, but ideally I would like to bring that tile to focus rather than opening a new getting started tab:
newtile

lramos15 added a commit that referenced this issue Jun 23, 2022
@lramos15 lramos15 added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Jun 23, 2022
@lramos15
Copy link
Member

Looks like this is possible with 'walkthroughs.selectStep' and just passing the step portion i.e. python.installPythonWin but I have added a PR to allow for using openWalkthrough to either open it if it's not open and if it is to reveal them

lramos15 added a commit that referenced this issue Jun 23, 2022
* Fix #152598

* Remove debug statement
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 23, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the June 2022 milestone Jun 23, 2022
@lramos15 lramos15 added the verification-found Issue verification failed label Jun 23, 2022
@lramos15
Copy link
Member

@karrtikr Please verify that openWalkthrough and walkthroughs.selectSteps works as expected now for you

@karrtikr
Copy link
Contributor Author

Yep walkthroughs.selectSteps does the job when the walkthrough is opened. Is there a way to test out openWalkthrough as the fix hasn't been released yet?

@lramos15
Copy link
Member

Yep walkthroughs.selectSteps does the job when the walkthrough is opened. Is there a way to test out openWalkthrough as the fix hasn't been released yet?

There is not please try it tomorrow 👍

@lramos15 lramos15 added verification-needed Verification of issue is requested and removed verification-found Issue verification failed labels Jun 24, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 24, 2022
@karrtikr
Copy link
Contributor Author

I can confirm it works, thanks!

@lramos15 lramos15 added the verified Verification succeeded label Jun 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality getting-started insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants