Profiles: Review new StorageScope for application and profile scope

[sandy081]

A Profile is a set of user's

• State (Storage)
• Settings
• Extensions
• Keyboard Shortcuts
• Tasks
• Snippets

With the introduction of Profiles, a user can now have multiple windows open with different profiles. This means the storage has to be scoped per profile. For eg., user can create a profile in which certain activitybar icons/statusbar icons/views are hidden. All windows opened using this profile shall retain this UI configuration and other windows shall have different UI configuration. At present this state is stored under newly introduced StorageScope.Profile scope and all state stored under this is scoped per profile. At the same time, some storage has to be scoped across application, for eg., the account used for settings sync or the workspace trust state. You can use the scope StorageScope.Application to store data that one can use across application. In brief, following are the storage scopes exists right now

• StorageScope.Application - The stored data will be scoped to all workspaces across all profiles. For eg:
  • Cached data (account session info for settings sync)
  • Workspace Trust state
  • Survey's state
  • Any state that is associated to a application scope setting
• StorageScope.Profile - The stored data will be scoped to all workspaces of the same profile. For eg:
  • UI layout
  • User preferences/choices
  • Input History (Search/Find etc.,)

With the introduction of StorageScope.Profile, please review your usage of StorageScope.Profile and use right scope.

• trustedDomains.ts @sbatten
• trustedDomainsFileSystemProvider.ts @sbatten
• integrityService.ts @alexdima
• contributedCustomEditors.ts @lramos15
• welcomeBanner.contribution.ts @lramos15
• editorResolverService.ts @lramos15
• findWidget.ts @rebornix
• notebookServiceImpl.ts @rebornix
• notebookKeymapServiceImpl.ts @rebornix
• debugToolBar.ts @roblourens
• notebookKernelServiceImpl.ts @roblourens
• notebookGettingStarted.ts @roblourens
• mainThreadAuthentication.ts @TylerLeonhardt
• authenticationService.ts @TylerLeonhardt
• gettingStarted.ts @sbatten
• gettingStartedService.ts @sbatten
• startupPage.ts @sbatten
• languageDetectionWorkerServiceImpl.ts @TylerLeonhardt
• referencesController.ts @jrieken
• suggestMemory.ts @jrieken
• suggestWidget.ts @jrieken
• commandsQuickAccess.ts @bpasero
• mainThreadFileSystemEventService.ts @jrieken
• layoutState.ts @sbatten
• editorPart.ts @bpasero
• menubarControl.ts @sbatten
• workbench.ts @bpasero
• bulkEditPane.ts @jrieken
• callHierarchy.contribution.ts @jrieken
• callHierarchyPeek.ts @jrieken
• extensionHostDebugService.ts @bpasero
• contributedOpeners.ts @mjbvz
• textFileSaveErrorHandler.ts @bpasero
• fileImportExport.ts @bpasero
• explorerViewItems.ts @alexr00
• scmService.ts @lszomoru
• snippetsService.ts @jrieken
• terminalInstance.ts @Tyriar
• terminalTabbedView.ts @Tyriar
• xtermTerminal.ts @Tyriar
• history.ts @Tyriar
• testingOutputPeek.ts @connor4312
• testExplorerFilterState.ts @connor4312
• typeHierarchy.contribution.ts @jrieken
• typeHierarchyPeek.ts @jrieken
• update.ts @joaomoreno
• window.ts @bpasero
• assignmentService.ts @sbatten
• extensionBisect.ts @jrieken
• extensionUrlHandler.ts @joaomoreno
• labelService.ts @connor4312
• remoteExplorerService.ts @alexr00
• sessionSyncWorkbenchService.ts @joyceerhl
• fileIconThemeData.ts @aeschli
• productIconThemeData.ts @aeschli
• workbenchThemeService.ts @aeschli
• colorThemeData.ts @aeschli
• nativeHostColorSchemeService.ts @aeschli
• timerService.ts @bpasero
• workspacesService.ts @bpasero

Following are the usages of donotShowAgain option in INotificationService. By default Notification Service stores do not show again state in application scope. The service also added NeverShowAgainScope.Application scope. So, also review these usages and choose the right scope.

• largeFileOptimizations.ts @bpasero
• textFileSaveErrorHandler.ts @bpasero
• remoteExplorer.ts @alexr00
• remoteExplorer.ts @alexr00
• terminalConfigHelper.ts @Tyriar
• workspaces.contribution.ts @bpasero
• workspaces.contribution.ts @bpasero

[sandy081]

@sbatten Assigned those areas which were previously owned by Jackson to you. Can you please reassign them to the correct owners. Thanks a lot.

[sandy081]

@sbatten Just want to check if the last two usages can be reviewed and adopted so that we can close this.

Thanks

[sandy081]

Thanks every one for reviewing and adopting.