Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash: unset: VSCODE_SHELL_LOGIN=' not a valid identifier #153033

Closed
meganrogge opened this issue Jun 23, 2022 · 1 comment · Fixed by #153042
Closed

bash: unset: VSCODE_SHELL_LOGIN=' not a valid identifier #153033

meganrogge opened this issue Jun 23, 2022 · 1 comment · Fixed by #153042
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
June 2022

Comments

@meganrogge
Copy link
Contributor

after running exit 100 in a terminal w shell integration enabled immediately after creation and the subsequent relaunch, I'm seeing this

Screen Shot 2022-06-23 at 1 10 56 PM
@meganrogge meganrogge added terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. terminal-shell-integration Shell integration, command decorations, etc. bug Issue identified by VS Code Team member as probable bug labels Jun 23, 2022
@meganrogge meganrogge added this to the June 2022 milestone Jun 23, 2022
@meganrogge
Copy link
Contributor Author

actually, repro is to just create a bash terminal

meganrogge added a commit that referenced this issue Jun 23, 2022
@meganrogge
fix #153033
2dc7108
@meganrogge meganrogge mentioned this issue Jun 23, 2022
Merged
meganrogge added a commit that referenced this issue Jun 23, 2022
@meganrogge
fix #153033 (#153042)
36b313c
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 23, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

fix #153033 microsoft/vscode
4 participants
@Tyriar @meganrogge @joyceerhl @VSCodeTriageBot