Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmd + K, Cmd + I should trigger custom hover in settings editor #153589

Closed
isidorn opened this issue Jun 28, 2022 · 2 comments
Closed

Cmd + K, Cmd + I should trigger custom hover in settings editor #153589

isidorn opened this issue Jun 28, 2022 · 2 comments
Assignees
@rzhao271
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2022

Testing #153351

When the user triggers the custom hover in this way we should pass focus to the hover.
That way it is aligned with the editor and other vs code parts and it would be more accessible.

fyi @Tyriar for custom hover since we had similar discussions
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 28, 2022

Also ran into this. I could not find a way to open the hover using just the keyboard

@Tyriar Tyriar added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 28, 2022
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Jun 28, 2022
@rzhao271 rzhao271 added this to the July 2022 milestone Jun 30, 2022
@rzhao271 rzhao271 modified the milestones: July 2022, August 2022 Jul 22, 2022
@rzhao271
Copy link
Contributor

Closing in favour of #159088

@rzhao271 rzhao271 removed this from the August 2022 milestone Aug 24, 2022
@rzhao271 rzhao271 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2022
@isidorn isidorn removed the bug Issue identified by VS Code Team member as probable bug label Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@isidorn @Tyriar @rzhao271 @mjbvz