Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Modified elsewhere indicator in the Settings editor #153351

Closed
2 tasks done
rzhao271 opened this issue Jun 27, 2022 · 1 comment
Closed
2 tasks done

Test: Modified elsewhere indicator in the Settings editor #153351

rzhao271 opened this issue Jun 27, 2022 · 1 comment

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Jun 27, 2022

Refs: #145731

Complexity: 3

Create Issue


The Modified elsewhere indicator is a new feature in the Settings editor that informs the user that the value of a setting has been modified elsewhere.

  1. Navigate to the Settings editor.
  2. Scroll through the settings.
  3. Many settings should already have the Modified elsewhere indicator show up. Hovering over the indicator should reveal a custom hover that notes down where else the setting has been modified. Verify that the link text makes sense, and that where the link navigates to makes sense.
  4. If a setting has only been modified in one other scope, and has no language-specific default overrides, then the Modified elsewhere indicator will not display. Instead, the old "Modified in/Also modified in" label will display. One way to test this out is to modify the diffEditor.codeLens setting only for the user scope of a specific language, and then change the scope and/or language filter and see what shows up.

Also verify that the current screenreader behaviour is as follows:

  1. If the user focuses on a setting, the screenreader reads a custom string that gives information about the Modified elsewhere indicator.
  2. If the user mouses over the indicator to show the custom hover, and then focuses on the hover contents by clicking on the hover, the screenreader currently reads off that text as-is.

Known issue: the user is currently unable to tab to any indicator specifically, or get the custom hover for the Modified elsewhere indicator to show up using the keyboard.

@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2022

@rzhao271 Very cool work, I really like this 👏 I think this will bring a lot of value to our users and help with some confusions.

@isidorn isidorn removed their assignment Jun 28, 2022
@mjbvz mjbvz closed this as completed Jun 28, 2022
@mjbvz mjbvz removed their assignment Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants