Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce actions in Default settings to copy/select settings #15361

Closed
sandy081 opened this issue Nov 11, 2016 · 3 comments
Closed

Introduce actions in Default settings to copy/select settings #15361

sandy081 opened this issue Nov 11, 2016 · 3 comments
Assignees
Milestone

Comments

@sandy081
Copy link
Member

Related #15162

  • Ability to copy/select a setting from default settings

In Default settings editor, If a setting is of boolean or an enum type, provide a dropdown to select the value and copy it. Otherwise just copy it to user/workspace settings.

@sandy081
Copy link
Member Author

@bgashler1 @stevencl

I would need your assistance on the following. I am working on settings story to improve on various aspects. One of those is to provide user a simpler way of copying a setting. Please see the following video and and feedback is very much appreciated and helpful.

Basically there are two kinds of actions

  • Select and copy: if a setting is of enum or boolean type, user can select to copy the setting.
  • Copy: Otherwise, setting will be copied with empty value.

nov-11-2016 16-21-54

@sandy081
Copy link
Member Author

@bgashler1 @stevencl I just pushed the changes. You can see the actions in the default settings editor if you run VS Code out of dev.

@s130059660
Copy link

Oh, sweet addition.

Is it possible to also copy the comments of descriptors and structures! So that we can immediately know each setting belong to which.

sandy081 added a commit that referenced this issue Nov 16, 2016
- Create a model for default settings and key bindings
- Move default settings actions as editor contributions
chrmarti added a commit that referenced this issue Nov 16, 2016
This reverts commit 463438e.
sandy081 added a commit that referenced this issue Nov 17, 2016
- Create a model for default settings and key bindings
- Move default settings actions as editor contributions
sandy081 added a commit that referenced this issue Nov 17, 2016
@sandy081 sandy081 closed this as completed Dec 7, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants