Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete should respect user preferences regarding confirmation #1538

Closed
papadi opened this issue Dec 21, 2015 · 4 comments
Closed

Delete should respect user preferences regarding confirmation #1538

papadi opened this issue Dec 21, 2015 · 4 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues on-testplan
Milestone
October 2017

Comments

@papadi
Copy link

papadi commented Dec 21, 2015

I have windows configured so that I don't need to confirm deletions. So on Windows explorer, when I hit DEL, the selected file is moved to the recycle bin directly. Many applications respect this and do not ask for confirmation either (eg. Visual Studio). It seems that VS Code does not respect this setting and ask for confirmation. This is wrong behavior.
@bpasero bpasero added feature-request Request for new features or functionality file-explorer Explorer widget issues labels Dec 21, 2015
@bpasero bpasero added this to the Backlog milestone Dec 21, 2015
@bpasero bpasero self-assigned this Mar 30, 2016
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Aug 14, 2016
@bpasero bpasero removed their assignment Aug 17, 2016
@nonbeing
Copy link

nonbeing commented Feb 1, 2017 •
edited

+1
would be great if the confirmation prompt could be enabled/disabled by a user setting.

@papadi
Copy link
Author

papadi commented Feb 1, 2017

I wouldn't go that way, but maybe. VS Code seems to be very configurable anyway. But default behavior should be to use Windows settings.

@michaeldaw
Copy link

I'd like to see a setting for this as well.

@bpasero bpasero mentioned this issue Oct 5, 2017
Closed
@bpasero bpasero closed this as completed in e956039 Oct 6, 2017
@bpasero
Copy link
Member

bpasero commented Oct 6, 2017

Introduced a new explorer.confirmDelete setting that allows to disable the confirmation dialog if the delete is using the trash.

This can also be set via the dialog by checking the "Do not ask me again" checkbox:

image

@bpasero bpasero self-assigned this Oct 6, 2017
@bpasero bpasero removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Oct 6, 2017
@bpasero bpasero modified the milestones: Backlog, October 2017 Oct 6, 2017
sandy081 pushed a commit that referenced this issue Oct 16, 2017
@bpasero @sandy081
Delete should respect user preferences regarding confirmation (fixes #…
530dfef 
…1538)
@bpasero bpasero mentioned this issue Oct 26, 2017
Closed
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues on-testplan
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
4 participants
@nonbeing @bpasero @papadi @michaeldaw