Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing commit message editor toolbar buttons #154628

Closed
beauxq opened this issue Jul 9, 2022 · 8 comments · Fixed by #162562
Closed

missing commit message editor toolbar buttons #154628

beauxq opened this issue Jul 9, 2022 · 8 comments · Fixed by #162562
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@beauxq
Copy link

beauxq commented Jul 9, 2022

Issue Type: Bug

vscode release notes 1.69.0 says:

To accept the commit message and complete the commit operation, [...] select the Accept Commit Message button in the editor toolbar.

I don't see any "Accept Commit Message button in the editor toolbar". The only button is the split editor button.

VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T08:29:47.439Z)
OS version: Linux x64 5.4.0-121-generic
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz (4 x 3499)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 11.60GB (2.14GB free)
Process Argv --unity-launch --crash-reporter-id e5a759f8-56e2-4ef2-8056-76b15f14ce2e
Screen Reader no
VM 0%
DESKTOP_SESSION cinnamon
XDG_CURRENT_DESKTOP X-Cinnamon
XDG_SESSION_DESKTOP cinnamon
XDG_SESSION_TYPE x11
Extensions (47)
Extension Author (truncated) Version
language-x86-64-assembly 13x 3.0.0
atlascode atl 2.10.12
language-gas-x86 bas 0.0.2
doxdocgen csc 1.4.0
dart-code Dar 3.44.0
flutter Dar 3.44.0
vscode-eslint dba 2.2.6
vscode-wasm dts 1.3.1
gitlens eam 12.1.1
go gol 0.34.1
rest-client hum 0.25.0
better-cpp-syntax jef 1.15.19
cmake-language-support-vscode jos 0.0.4
sublime-babel-vscode jos 0.2.10
Lua key 0.0.9
mypy mat 0.2.2
asm-code-lens maz 1.10.2
git-graph mhu 1.30.0
vscode-docker ms- 1.22.0
vscode-dotnet-runtime ms- 1.5.0
python ms- 2022.10.0
vscode-pylance ms- 2022.7.20
jupyter ms- 2022.6.1001902341
jupyter-keymap ms- 1.0.0
jupyter-renderers ms- 1.0.8
remote-containers ms- 0.241.3
remote-ssh ms- 0.82.1
remote-ssh-edit ms- 0.80.0
remote-wsl ms- 0.66.3
vscode-remote-extensionpack ms- 0.21.0
cmake-tools ms- 1.11.26
cpptools ms- 1.11.2
cpptools-extension-pack ms- 1.2.0
hexeditor ms- 1.9.7
vscode-typescript-tslint-plugin ms- 1.3.4
vetur oct 0.35.0
ruby reb 0.28.1
vscode-yaml red 1.8.0
LiveServer rit 5.7.5
wow-bundle Sep 1.3.0
code-spell-checker str 2.3.0
lua sum 3.4.2
svelte-vscode sve 105.18.1
pdf tom 1.2.0
vscode-lua tri 0.12.4
cmake twx 0.0.17
vscode-ruby win 0.28.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
vsclangdc:30486549

@lszomoru
Copy link
Member

The editor toolbar buttons only appear when the COMMIT_EDITMSG file is opened in the editor:

image

@lszomoru lszomoru added info-needed Issue requires more information from poster git GIT issues labels Jul 11, 2022
@beauxq
Copy link
Author

beauxq commented Jul 11, 2022

no buttons

@lszomoru
Copy link
Member

Thanks! Would you be able to share a screenshot of the complete workbench? What is the language name that is shown in the lower right hand corner in the status bar? By default the COMMIT_EDITMSG file should be detected as "Git Commit Message".

@beauxq
Copy link
Author

beauxq commented Jul 12, 2022

It does have "Git Commit Message" as the file type.

I think maybe I figured out how you can reproduce it:
The buttons appear for a normal git repository. The buttons don't appear for a git submodule.

When I press the top commit button, I get the buttons. When I press the bottom commit button, no buttons.

commit-buttons
.
Are you able to reproduce it that way?

@VSCodeTriageBot
Copy link
Collaborator

Hey @lszomoru, this issue might need further attention.

@beauxq, you can help us out by closing this issue if the problem no longer exists, or adding more information.

@beauxq
Copy link
Author

beauxq commented Sep 30, 2022

issue still present in 1.71.2

@lszomoru
Copy link
Member

lszomoru commented Oct 1, 2022

@beauxq, sorry for not getting back to you on this, as the notification felt through the cracks.
Let me see if I am able to reproduce the problem based on the latest information that you have shared.

@lszomoru
Copy link
Member

lszomoru commented Oct 1, 2022

@beauxq, I've got a repro and I should be able to get a fix in for this next week. Thank you for the repro details!

@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Oct 3, 2022
@lszomoru lszomoru added this to the October 2022 milestone Oct 3, 2022
lszomoru added a commit that referenced this issue Oct 3, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 3, 2022
@alexr00 alexr00 added the verified Verification succeeded label Oct 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@lszomoru @beauxq @alexr00 @VSCodeTriageBot and others