Closing dialog does not cancel (Manjaro Linux)

[NicoWeio]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.68.1, 1.69.0
• OS Version: Manjaro Linux 21.3.1, 21.3.3

Steps to Reproduce:

1. Create a new text file (Ctrl+N)
2. Set the language mode to something you don't have a formatter for (e.g. LaTeX)
3. Invoke Format document (Ctrl+Shift+I)
4. A dialog opens, which says “There is no formatter for latex files installed.” and allows the user to a) install one or b) cancel.
5. Close the modal either by pressing Esc, by pressing the X on the window decoration, or by pressing Ctrl+F4
6. The Extensions pane opens, even though the user wanted to cancel.

I can't reproduce this using Codespaces / VNC on main, but on multiple machines running Manjaro.

Some relevant code snippets:

vscode/src/vs/workbench/contrib/format/browser/formatActionsNone.ts

Lines 68 to 75 in 54dec24

	const res = await dialogService.show(
	Severity.Info,
	message,
	[nls.localize('cancel', "Cancel"), nls.localize('install.formatter', "Install Formatter...")]
	);
	if (res.choice === 1) {
	showExtensionQuery(paneCompositeService, `category:formatters ${langName}`);
	}

vscode/src/vs/platform/dialogs/common/dialogs.ts

Lines 223 to 230 in 54dec24

	/**
	* Present a modal dialog to the user.
	*
	* @returns A promise with the selected choice index. If the user refused to choose,
	* then a promise with index of `cancelId` option is returned. If there is no such
	* option then promise with index `0` is returned.
	*/
	show(severity: Severity, message: string, buttons?: string[], options?: IDialogOptions): Promise<IShowResult>;

[jrieken]

@bpasero I am reading this wrongly or is there a bug with the dialog service? I am not providing cancelId, assuming it defaults to 0 so that my logic only works for the 1 case

[bpasero]

See #155049

[VSCodeTriageBot]

This bug has been fixed in the latest release of VS Code Insiders!

@NicoWeio, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 1cd90cc of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

[NicoWeio]

/verified