Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reloading window with dirty files shows save dialog #15509

Closed
bpasero opened this issue Nov 15, 2016 · 3 comments
Closed

Reloading window with dirty files shows save dialog #15509

bpasero opened this issue Nov 15, 2016 · 3 comments
Assignees
@bpasero @Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X verified Verification succeeded workbench-hot-exit Preservation of unsaved changes across restarts
Milestone
November 2016

Comments

@bpasero
Copy link
Member

bpasero commented Nov 15, 2016

I hope I did not break this, but when I reload the window with dirty files and hot exit enabled, I am getting prompted to save.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-hot-exit Preservation of unsaved changes across restarts labels Nov 15, 2016
@Tyriar
Copy link
Member

Tyriar commented Nov 15, 2016

Was it an empty workspace? Can't repro on today's insiders or master?

@bpasero
Copy link
Member Author

bpasero commented Nov 16, 2016

@Tyriar yes, reproduces in insiders for me:

  • enable hot exit
  • have a new untitled file with changes
  • Cmd/Ctrl+R

@Tyriar
Copy link
Member

Tyriar commented Nov 16, 2016 •
edited

Ah, this is Mac-specific due to it only triggering hot exit when you close all windows. So reload should behave a little differently to a regular window close on Mac.

@Tyriar Tyriar added the macos Issues with VS Code on MAC/OS X label Nov 16, 2016
@Tyriar Tyriar added this to the November 2016 milestone Nov 16, 2016
@bpasero bpasero mentioned this issue Nov 29, 2016
Merged
@bpasero bpasero self-assigned this Nov 29, 2016
bpasero added a commit that referenced this issue Nov 29, 2016
@bpasero
Merge pull request #16198 from Microsoft/ben/hot-exit-reload
5aeba8b 
introduce shutdown reason (fixes #15509)
@roblourens roblourens added the verified Verification succeeded label Dec 9, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X verified Verification succeeded workbench-hot-exit Preservation of unsaved changes across restarts
Projects
None yet
Milestone
November 2016
Development

No branches or pull requests
3 participants
@roblourens @bpasero @Tyriar