check if values are true not just undefined #155348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Jul 15, 2022
meganrogge
commented
Jul 15, 2022
meganrogge
commented
Jul 15, 2022
roblourens
approved these changes
Jul 16, 2022
joaomoreno
added a commit
that referenced
this pull request
Jul 18, 2022
This reverts commit 7839742.
|
FYI reverted this due to build breakage: #155468 |
joaomoreno
added a commit
that referenced
this pull request
Jul 18, 2022
jrieken
pushed a commit
that referenced
this pull request
Jul 18, 2022
jrieken
pushed a commit
that referenced
this pull request
Jul 18, 2022
Tyriar
reviewed
Jul 18, 2022
| @@ -2173,7 +2174,7 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer | |||
| } | |||
|
|
|||
| private get _jsonTasksSupported(): boolean { | |||
| return !!ShellExecutionSupportedContext.getValue(this._contextKeyService) && !!ProcessExecutionSupportedContext.getValue(this._contextKeyService); | |||
| return ShellExecutionSupportedContext.getValue(this._contextKeyService) === true && ProcessExecutionSupportedContext.getValue(this._contextKeyService) === true && !Platform.isWeb; | |||
There was a problem hiding this comment.
This !Platform.isWeb was the problem:
5 failing
1) VSCode Smoke Tests (Web)
Task
Task Quick Pick
Tasks: Run Task
hide property - false:
Error: Timeout: get elements '.quick-input-widget .quick-input-list .monaco-list-row .label-name' after 20 seconds.
at Code.poll (D:\a\_work\1\s\test\automation\src\code.ts:255:11)
at Code.waitForElements (D:\a\_work\1\s\test\automation\src\code.ts:204:10)
at QuickInput.waitForQuickInputElements (D:\a\_work\1\s\test\automation\src\quickinput.ts:41:3)
at Task.assertTasks (D:\a\_work\1\s\test\automation\src\task.ts:42:4)
at Context.<anonymous> (src\areas\task\task-quick-pick.test.ts:36:5)
2) VSCode Smoke Tests (Web)
Task
Task Quick Pick
Tasks: Run Task
hide property - undefined:
Error: Timeout: get elements '.quick-input-widget .quick-input-list .monaco-list-row .label-name' after 20 seconds.
at Code.poll (D:\a\_work\1\s\test\automation\src\code.ts:255:11)
at Code.waitForElements (D:\a\_work\1\s\test\automation\src\code.ts:204:10)
at QuickInput.waitForQuickInputElements (D:\a\_work\1\s\test\automation\src\quickinput.ts:41:3)
at Task.assertTasks (D:\a\_work\1\s\test\automation\src\task.ts:42:4)
at Context.<anonymous> (src\areas\task\task-quick-pick.test.ts:40:5)
3) VSCode Smoke Tests (Web)
Task
Task Quick Pick
Tasks: Run Task
icon - icon only:
Error: Timeout: get elements '.quick-input-widget .quick-input-list .monaco-list-row .label-name' after 20 seconds.
at Code.poll (D:\a\_work\1\s\test\automation\src\code.ts:255:11)
at Code.waitForElements (D:\a\_work\1\s\test\automation\src\code.ts:204:10)
at QuickInput.waitForQuickInputElements (D:\a\_work\1\s\test\automation\src\quickinput.ts:41:3)
at Task.assertTasks (D:\a\_work\1\s\test\automation\src\task.ts:42:4)
at Context.<anonymous> (src\areas\task\task-quick-pick.test.ts:45:5)
|
Second try: #155524 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #155227
fixes #155336