Tasks are requesting workspace trust on startup

[sbatten]

Type: Bug

This just started happening in today's insiders but affects insiders.vscode.dev as well. It seems that tasks are requesting workspace trust on launch which causes a double prompt in some cases.

VS Code version: Code - Insiders 1.70.0-insider (e0a65a9, 2022-07-14T05:17:15.290Z)
OS version: Windows_NT x64 10.0.22000
Modes:

System Info

Item	Value
CPUs	AMD Ryzen 9 3900X 12-Core Processor (24 x 3800)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.92GB (14.80GB free)
Process Argv	--crash-reporter-id 3434a1e9-60b7-446b-986c-27c6457bc73d
Screen Reader	no
VM	21%

[meganrogge]

Since we want tasks to reconnect on window reload and tasks require workspace trust, I am not sure what to do about this. @Tyriar or @alexr00 thoughts?

[Tyriar]

@sbatten shouldn't the double prompt be prevented and shared inside the workspace trust code?

[sbatten]

this is happening even in cases where a prompt should never happen. e.g. opening a PR in insiders.vscode.dev. it seems like we are trying to execute some tasks code even if no tasks are around to reconnect to

[meganrogge]

this will happen if there are any recently used tasks atm

[meganrogge]

because we don't know ahead of time which of those should be reconnected to (has a corresponding terminal that will be revived)

[sbatten]

in most web scenarios there is not terminal? http://insiders.vscode.dev/https://github.com/microsoft/vscode/pull/155223 I get prompted in this case

[meganrogge]

yeah I should be checking that - I'm surprised the task service even gets created in the web context

[meganrogge]

fixed it from a task/terminal perspective
#155233

[meganrogge]

this is now checked before reconnecting

https://github.com/amanasifkhalid/vscode/blob/cb1c894367692b72218ea4cc27eb93f5a2252dc2/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts#L2175-L2178