Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task dialog could benefit from separation of title and details #156287

Closed
bpasero opened this issue Jul 26, 2022 · 3 comments · Fixed by #156919 or #157020
Closed

Task dialog could benefit from separation of title and details #156287

bpasero opened this issue Jul 26, 2022 · 3 comments · Fixed by #156919 or #157020
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue tasks Task system issues verified Verification succeeded
Milestone
August 2022

Comments

@bpasero
Copy link
Member

bpasero commented Jul 26, 2022

Testing #155350

image
@bpasero
Copy link
Member Author

bpasero commented Jul 26, 2022

I also wonder why none of the buttons are focused by default?

@meganrogge meganrogge added the tasks Task system issues label Jul 26, 2022
@meganrogge meganrogge added this to the August 2022 milestone Jul 26, 2022
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue labels Jul 26, 2022
@meganrogge
Copy link
Contributor

@bpasero I don't see a way via the dialogService.show to indicate which should be pre-selected

meganrogge added a commit that referenced this issue Aug 2, 2022
@meganrogge
fix #156287
c67ce2f
@meganrogge meganrogge mentioned this issue Aug 2, 2022
Merged
meganrogge added a commit that referenced this issue Aug 2, 2022
@meganrogge
add separation to task detection notification (#156919)
5f8c264 
fix #156287
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 2, 2022
@bpasero bpasero reopened this Aug 3, 2022
@bpasero
Copy link
Member Author

bpasero commented Aug 3, 2022

Try setting the cancelId option as well.

@VSCodeTriageBot VSCodeTriageBot removed the unreleased Patch has not yet been released in VS Code Insiders label Aug 3, 2022
@Tyriar Tyriar removed their assignment Aug 3, 2022
@meganrogge meganrogge mentioned this issue Aug 3, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 3, 2022
@connor4312 connor4312 added the verified Verification succeeded label Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue tasks Task system issues verified Verification succeeded
Projects
None yet
Milestone
August 2022
5 participants
@bpasero @Tyriar @connor4312 @meganrogge @VSCodeTriageBot