Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noticable performance hang when dismissing a large number of items #156314

Closed
connor4312 opened this issue Jul 26, 2022 · 0 comments · Fixed by #156963
Closed

Noticable performance hang when dismissing a large number of items #156314

connor4312 opened this issue Jul 26, 2022 · 0 comments · Fixed by #156963
Assignees
@andreamah
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues insiders-released Patch has been released in VS Code Insiders perf verified Verification succeeded
Milestone
August 2022

Comments

@connor4312
Copy link
Member

Testing #156196

  1. In the vscode remote, search for commandService
  2. Select the majority of the list
  3. Dismiss them
  4. Notice the UI is unresponsive for a few seconds

Profile: Profile-20220726T091056.json.zip
@andreamah andreamah added the perf label Jul 27, 2022
@andreamah andreamah added this to the Backlog milestone Jul 27, 2022
@andreamah andreamah added the debt Code quality issues label Aug 2, 2022
@andreamah andreamah modified the milestones: Backlog, August 2022 Aug 2, 2022
@andreamah andreamah mentioned this issue Aug 3, 2022
Merged
andreamah added a commit that referenced this issue Aug 3, 2022
@andreamah
Noticable performance hang when dismissing a large number of items
1f13521 
Fixes #156314
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 16, 2022
pull bot pushed a commit to Prequal-Digital/vscode that referenced this issue Aug 16, 2022
@andreamah
Noticeable performance hang when dismissing a large number of items (m…
886ef21 
…icrosoft#156963)

* Noticeable performance hang when dismissing a large number of items
Fixes microsoft#156314
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 17, 2022
@andreamah andreamah added the bug Issue identified by VS Code Team member as probable bug label Aug 23, 2022
@mjbvz mjbvz added the verified Verification succeeded label Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andreamah andreamah

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues insiders-released Patch has been released in VS Code Insiders perf verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

Noticable performance hang when dismissing a large number of items microsoft/vscode
4 participants
@connor4312 @mjbvz @andreamah @VSCodeTriageBot