Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The left margin of Terminal is large when terminal.integrated.shellIntegration.decorationsEnabled: "never" #156386

Closed
tamuratak opened this issue Jul 27, 2022 · 0 comments · Fixed by #158795
Closed

The left margin of Terminal is large when terminal.integrated.shellIntegration.decorationsEnabled: "never" #156386

tamuratak opened this issue Jul 27, 2022 · 0 comments · Fixed by #158795
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
August 2022

Comments

@tamuratak
Copy link
Contributor

Version: 1.70.0-insider (Universal)
Commit: cc098fa
Date: 2022-07-26T05:17:37.262Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Darwin arm64 20.6.0

Steps to Reproduce:

  1. Put Terminal on Secondary Side Bar.
  2. Set terminal.integrated.shellIntegration.decorationsEnabled: "never"
  3. The left margin shrinks.
  4. Reload VS Code.
  5. The left margin has expanded.

Even setting terminal.integrated.shellIntegration.enabled: false, this issue happens.

Before:
normal

Set terminal.integrated.shellIntegration.decorationsEnabled: "never":

setnever

Reload VS Code:
afterreload
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. labels Jul 27, 2022
@meganrogge meganrogge added this to the August 2022 milestone Jul 27, 2022
Tyriar added a commit that referenced this issue Aug 22, 2022
@Tyriar
Fix initial application of shell-integration class
7c6b874 
Fixes #156386
@Tyriar Tyriar mentioned this issue Aug 22, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 22, 2022
@mjbvz mjbvz added the verified Verification succeeded label Aug 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

Fix initial application of shell-integration class microsoft/vscode
5 participants
@Tyriar @tamuratak @mjbvz @meganrogge @VSCodeTriageBot