Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noticable performance hang when dismissing a large number of items #156963

Merged
merged 20 commits into from
Aug 16, 2022
Merged

Noticable performance hang when dismissing a large number of items #156963

merged 20 commits into from
Aug 16, 2022

Conversation

andreamah
Copy link
Contributor

Fixes #156314

@andreamah andreamah self-assigned this Aug 3, 2022
@andreamah andreamah marked this pull request as ready for review August 9, 2022 18:13
@VSCodeTriageBot VSCodeTriageBot added this to the August 2022 milestone Aug 9, 2022
roblourens
roblourens reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to get some unit tests for the new SearchResult APIs

src/vs/workbench/contrib/search/browser/searchActions.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/search/common/searchModel.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/search/common/searchModel.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/search/common/searchModel.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/search/common/searchModel.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/search/common/searchModel.ts Outdated Show resolved Hide resolved
@roblourens
Copy link
Member

Some odd things I'm seeing which we should file issues for, but don't have to be fixed in this PR

  • When I'm waiting for 1000s of items to be replaced, there is no feedback that anything is happening. We should show the viewlet progress bar, like when you click "Replace All"
  • Something weird, maybe a disconnect between list focus and list selection. Do a multiselection, click Replace, then shift+click another element. It should select all elements between the selected and clicked element, but it selects extra elements (maybe from the focused to the clicked element)
    Recording 2022-08-15 at 11 46 33

This was referenced Aug 16, 2022
Open
Open
@andreamah andreamah enabled auto-merge (squash) August 16, 2022 16:40
@andreamah andreamah merged commit 886ef21 into main Aug 16, 2022
@andreamah andreamah deleted the andreamah/issue156314 branch August 16, 2022 20:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@andreamah andreamah

Labels
None yet
Projects
None yet
Milestone
August 2022
Development

Successfully merging this pull request may close these issues.

Noticable performance hang when dismissing a large number of items
3 participants
@andreamah @roblourens @VSCodeTriageBot