Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy and workspace trust can switch to using Setting indicators #157564

Closed
4 tasks done
rzhao271 opened this issue Aug 8, 2022 · 2 comments
Closed
4 tasks done

Policy and workspace trust can switch to using Setting indicators #157564

rzhao271 opened this issue Aug 8, 2022 · 2 comments
Assignees
@rzhao271
Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues
Milestone
October 2022

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Aug 8, 2022 •
edited
Loading

Currently in the GUI Settings editor, settings affected by policies or untrusted workspaces display large alerts that also disallow the user to change the setting value.
Instead, we can consider moving those alerts into the indicators area, which is the area around each setting where indicators such as "Also modified in" can show up.

Done:

  • Change the configurationService to return the values for all scopes even for policy and workspace restricted settings, while keeping the actual inspected value the same as before. @sandy081
  • Change the UI to use indicators for policies and workspace trust. @rzhao271

Todo:

  • Get some rounds of feedback
  • Write TPIs for policy and workspace trust settings in the Settings editor
@rzhao271 rzhao271 added this to the August 2022 milestone Aug 8, 2022
@rzhao271 rzhao271 self-assigned this Aug 8, 2022
@rzhao271 rzhao271 added feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Aug 8, 2022
@kieferrm kieferrm mentioned this issue Aug 15, 2022
Closed
@rzhao271 rzhao271 added the config VS Code configuration, set up issues label Aug 15, 2022
@rzhao271 rzhao271 modified the milestones: August 2022, September 2022 Aug 23, 2022
@kieferrm kieferrm mentioned this issue Sep 4, 2022
Closed
@sandy081 sandy081 mentioned this issue Sep 20, 2022
Merged
@rzhao271 rzhao271 modified the milestones: September 2022, October 2022 Sep 26, 2022
@kieferrm kieferrm mentioned this issue Oct 8, 2022
Closed
77 tasks
@rzhao271 rzhao271 mentioned this issue Oct 13, 2022
Merged
1 task
@rzhao271
Copy link
Contributor Author

\closedWith 740d837

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 14, 2022
This was referenced Oct 21, 2022
Merged
Closed
@rzhao271 rzhao271 mentioned this issue Oct 24, 2022
Merged
@rzhao271
Copy link
Contributor Author

Adding a link to the epic #147756

@rzhao271 rzhao271 mentioned this issue Oct 24, 2022
Closed
2 tasks
@rzhao271 rzhao271 mentioned this issue Nov 3, 2022
Merged
rzhao271 added a commit that referenced this issue Nov 3, 2022
@rzhao271
Remove redundant CSS rules
c3b1f3c 
Ref #165169
Ref #157564

After changing workspace trust and policy settings
to use indicators, a bunch of CSS rules became redundant.
This PR removes those CSS rules.
rzhao271 added a commit that referenced this issue Nov 3, 2022
@rzhao271
Remove redundant CSS rules (#165401)
78f27b8 
Ref #165169
Ref #157564

After changing workspace trust and policy settings
to use indicators, a bunch of CSS rules became redundant.
This PR removes those CSS rules.
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues
Projects
None yet
Milestone
October 2022
Development

No branches or pull requests
3 participants
@rzhao271 @sandy081 @VSCodeTriageBot