Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provideCellStatusBarItems Test Fail on MacOS #157828

Closed
andreamah opened this issue Aug 10, 2022 · 4 comments · Fixed by #161274
Closed

provideCellStatusBarItems Test Fail on MacOS #157828

andreamah opened this issue Aug 10, 2022 · 4 comments · Fixed by #161274
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders integration-test-failure

Comments

@andreamah
Copy link
Contributor

From https://dev.azure.com/monacotools/Monaco/_build/results?buildId=181401&view=logs&j=9833cdaa-2e92-5f8d-56a8-239fd18fd628&t=9bc48eac-eb66-52c8-7250-d6490c5f3a15

  1) statusbar
       provideCellStatusBarItems called on metadata change:
     Error: asPromise TIMEOUT reached
      at asPromise (extensions/vscode-api-tests/src/utils.ts:128:16)
      at Context.<anonymous> (extensions/vscode-api-tests/src/singlefolder-tests/notebook.api.test.ts:291:34)
      at processImmediate (node:internal/timers:466:21)

@rebornix
Copy link
Member

The core might have heuristics of if/when provideCellStatusBarItems should be called, maybe this test can be turned into a unit test first?

@rebornix rebornix removed their assignment Aug 11, 2022
@rebornix rebornix changed the title Notebook API Test Fail on MacOS provideCellStatusBarItems Test Fail on MacOS Aug 11, 2022
@roblourens
Copy link
Member

Was just looking at this. That might make sense too, but it also seems to make sense to test this as an API contract.

@roblourens
Copy link
Member

Is it going to make a difference if I move off the deprecated WorkspaceEdit api?

@roblourens
Copy link
Member

roblourens commented Aug 11, 2022

The issue you have mentioned with the editor service, I wonder if that could be in play here because this failure is just implying that the cell did not get rendered and initially request statusbar items.

This test also doesn't make sense because it's just awaiting the same promise twice 🤦

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders integration-test-failure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants