-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provideCellStatusBarItems Test Fail on MacOS #157828
Comments
The core might have heuristics of if/when |
Was just looking at this. That might make sense too, but it also seems to make sense to test this as an API contract. |
Is it going to make a difference if I move off the deprecated WorkspaceEdit api? |
The issue you have mentioned with the editor service, I wonder if that could be in play here because this failure is just implying that the cell did not get rendered and initially request statusbar items. This test also doesn't make sense because it's just awaiting the same promise twice 🤦 |
From https://dev.azure.com/monacotools/Monaco/_build/results?buildId=181401&view=logs&j=9833cdaa-2e92-5f8d-56a8-239fd18fd628&t=9bc48eac-eb66-52c8-7250-d6490c5f3a15
The text was updated successfully, but these errors were encountered: