Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell integration: Directory history doesn't handle directory names which require quotes (e.g. containing spaces) #157890

Closed
jhoneill opened this issue Aug 11, 2022 · 0 comments · Fixed by #158051
Closed

Shell integration: Directory history doesn't handle directory names which require quotes (e.g. containing spaces) #157890

jhoneill opened this issue Aug 11, 2022 · 0 comments · Fixed by #158051
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
August 2022

Comments

@jhoneill
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: Version: 1.70.1 (user setup)
    Commit: 6d9b74a
    Date: 2022-08-10T06:08:33.642Z
    Electron: 18.3.5
    Chromium: 100.0.4896.160
    Node.js: 16.13.2
    V8: 10.0.139.17-electron.0
    OS: Windows_NT x64 10.0.19042
  • OS Version: Microsoft Windows NT 10.0.19042.0

Steps to Reproduce:

  1. Enable Shell integration
  2. In a PowerShell window change directory to , for example, C:\program files
  3. Press F1, select Terminal, Go to Recent Directory...
  4. Choose C:\Program Files
  5. Terminal runs cd c:\program files without quotes around the name and sees files as an additional parameter.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. labels Aug 11, 2022
@Tyriar Tyriar added this to the August 2022 milestone Aug 11, 2022
Tyriar added a commit that referenced this issue Aug 12, 2022
@Tyriar
Escape go to dirs with spaces properly
ff94187 
Fixes #157890
@Tyriar Tyriar mentioned this issue Aug 12, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 13, 2022
@roblourens roblourens added the verified Verification succeeded label Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

Escape go to dirs with spaces properly microsoft/vscode
5 participants
@roblourens @Tyriar @jhoneill @meganrogge @VSCodeTriageBot