Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve screen reader detection on macOS #158008

Closed
isidorn opened this issue Aug 12, 2022 · 3 comments · Fixed by #161663
Closed

Improve screen reader detection on macOS #158008

isidorn opened this issue Aug 12, 2022 · 3 comments · Fixed by #161663
Assignees
@deepak1556
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone
September 2022

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 12, 2022

On MacOS we seem to have an unexpected high amount of screen reader users as discovered by @devinvalenciano

@deepak1556 found the corresponding Chromium issue which is not part of our Electron https://bugs.chromium.org/p/chromium/issues/detail?id=1143047

Even though the issue does not mention false positives, we should take it and hope that this will make the detection on macOS more precise.
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Aug 12, 2022
@isidorn isidorn added this to the August 2022 milestone Aug 12, 2022
@isidorn
Copy link
Contributor Author

isidorn commented Aug 12, 2022

@devinvalenciano has confirmed that most of the accessibility users detected on macOS are on Monterey and BigSur. Thus they could be affected by this bug.

@kieferrm kieferrm mentioned this issue Sep 6, 2022
Closed
@deepak1556 deepak1556 mentioned this issue Sep 24, 2022
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Sep 26, 2022
@isidorn
Copy link
Contributor Author

isidorn commented Sep 26, 2022

@deepak1556 thanks a lot for doing this 👏 I can verify tomorrow once it gets into Insiders.

@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 26, 2022
@mjbvz mjbvz added the author-verification-requested Issues potentially verifiable by issue author label Sep 29, 2022
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@isidorn, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 2c80125 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@isidorn isidorn added the verified Verification succeeded label Sep 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

chore: update electron@19.0.17 microsoft/vscode
4 participants
@deepak1556 @isidorn @mjbvz @vscodenpa