Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code action widget doesn't have border in high contrast theme #158030

Closed
mjbvz opened this issue Aug 12, 2022 · 1 comment · Fixed by #158034
Closed

Code action widget doesn't have border in high contrast theme #158030

mjbvz opened this issue Aug 12, 2022 · 1 comment · Fixed by #158034
Assignees
@justschen
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone
August 2022

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Aug 12, 2022 •
edited

Type: Bug

  1. Switch to high contrast dark
  2. Open new code action widget

Bug
It's hard to tell where the widget is since it doesn't have a border

Screen Shot 2022-08-12 at 11 19 22 AM

Take a look at the suggest widget for what this should look like

VS Code version: Code - Insiders 1.71.0-insider (Universal) (eebdf81, 2022-08-12T05:18:44.014Z)
OS version: Darwin x64 21.6.0
Modes:
Sandboxed: Yes

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) 4, 4, 4
Memory (System) 32.00GB (0.03GB free)
Process Argv --crash-reporter-id 48781ca2-1705-4f64-9bab-325055aab55d
Screen Reader no
VM 0%
@mjbvz mjbvz added this to the August 2022 milestone Aug 12, 2022
@justschen
Copy link
Contributor

Taking a look at this right now - the entire widget actually just doesn't have a border atm :(

@justschen justschen mentioned this issue Aug 12, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 12, 2022
Yoyokrazy pushed a commit that referenced this issue Aug 12, 2022
@justschen
Code action widget style fixes and fix #158030
4b6ab49 
* added disabled hover

* code cleanup on disabled option hovers

* removed comments

* widget enabled by default

* code cleanup and fix on build

* clean up on css removed unused importants

* small patch for css rules

* minor refactor on codeactionitems

* fix on disabled option click

* fix on disabled option click

* added some icons but just temp

* added iconws and modified widget look

* added beginning logic for menu groupings

* looks pretty good for a menu wooo

* added headers to menu + removed extra text from option labels

* minor code cleanup on group filtering

* Refactoring on code action kind

* changed styling based on feedback

* code cleanup

* First couple of fixes on PR for code action kinds

* modified icons and refactoring

* removed extra push

* removed parsing and added code action kind for surround

* minor style fixes and fix on border
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@justschen justschen

Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

Code action widget style fixes and fix #158030 justschen/vscode
3 participants
@mjbvz @justschen @VSCodeTriageBot