Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Settings That Got Added/Whose Default Value Has Changed In Last Release #158144

Closed
hediet opened this issue Aug 15, 2022 · 11 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues

Comments

@hediet
Copy link
Member

hediet commented Aug 15, 2022

To prevent user confusion when new features are added/enabled by default, it might be a good idea to tag settings that got introduced in the last release or whose default value changed.

The idea was suggesten in #157325 (comment) and could look like this:

@isidorn
Copy link
Contributor

isidorn commented Aug 15, 2022

We could also support a @new filter to filter to these settings only.

@gjsjohnmurray
Copy link
Contributor

Related to this, how about having a "What's New in VS Code" walkthrough which gets updated for each release? I think a walkthrough could coax users to opt in to new features that the team wants to promote. It would be a less contentious approach than changing defaults, making some folk unhappy and requiring them to work out how to opt out.

@IllusionMH
Copy link
Contributor

I think there were requests for more general feature - add settings filter by version (and "new" would be one of possible filters) but I can't find them :(

But that approach would allow for filters and labels.

@isidorn
Copy link
Contributor

isidorn commented Aug 15, 2022

@gjsjohnmurray what you are proposing is an advanced version of our release notes experience. You would like it to be interactive. While I think it makes sense, I am not sure we should invest resources in this yet. I am more worried about new users coming to vscode and not discovering simple things like the quick pick...

@gjsjohnmurray
Copy link
Contributor

@isidorn we already have a pretty good "Get Started with VS Code" walkthrough. I think by adding a "What's New in VS Code 1.71" walkthrough we could highlight a few key items and encourage opt-in.

@isidorn
Copy link
Contributor

isidorn commented Aug 15, 2022

@gjsjohnmurray aha so you are proposing a walkthrough per release. I guess that makes sense.

fyi @digitarald @misolori

@rzhao271 rzhao271 added the under-discussion Issue is under discussion for relevance, priority, approach label Dec 5, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Dec 5, 2022

A new filter could work. Would this feature only apply to core settings?
Also, to find the new settings, I'm thinking we would have to diff the old defaultSettings.json file against the new one and pick out the revisions. Let me know if y'all had another idea in mind.

@hediet
Copy link
Member Author

hediet commented Dec 6, 2022

We could introduce a date when a new setting is introduced/the default value is changed.

@rzhao271 rzhao271 added this to the Backlog milestone Dec 6, 2022
@rzhao271 rzhao271 added the settings-editor VS Code settings editor issues label Dec 6, 2022
@sandy081 sandy081 added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Dec 8, 2022
@sandy081 sandy081 modified the milestones: Backlog, Backlog Candidates Dec 8, 2022
@VSCodeTriageBot
Copy link
Collaborator

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot
Copy link
Collaborator

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot
Copy link
Collaborator

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

7 participants