Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rounded corners to buttons #158315

Merged
merged 2 commits into from Aug 17, 2022
Merged

Add rounded corners to buttons #158315

merged 2 commits into from Aug 17, 2022

Conversation

miguelsolorio
Copy link
Contributor

@miguelsolorio miguelsolorio commented Aug 16, 2022 •
edited

Partially fixes #147121 and adds a 2px border-radius on all of our buttons, including split buttons to better align with our other rounded corners.

CleanShot.2022-08-16.at.13.03.59.mp4

And a few other variants

CleanShot 2022-08-16 at 13 08 07@2x

CleanShot 2022-08-16 at 13 08 37@2x

CleanShot 2022-08-16 at 13 10 42@2x

cc @lszomoru

@miguelsolorio miguelsolorio marked this pull request as ready for review August 17, 2022 22:59
@miguelsolorio miguelsolorio added this to the August 2022 milestone Aug 17, 2022
@miguelsolorio miguelsolorio merged commit cd68530 into main Aug 17, 2022
@miguelsolorio miguelsolorio deleted the misolori/original-octopus-buttons branch August 17, 2022 23:01
@daviddossett daviddossett mentioned this pull request Aug 30, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lszomoru lszomoru lszomoru approved these changes

Assignees

@miguelsolorio miguelsolorio

Labels
None yet
Projects
None yet
Milestone
August 2022
Development

Successfully merging this pull request may close these issues.

Explore using a subtle border radius on common inputs
2 participants
@miguelsolorio @lszomoru