Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Update button border radius #401

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Update button border radius #401

merged 2 commits into from
Aug 30, 2022

Conversation

@daviddossett
Copy link
Collaborator

@daviddossett daviddossett commented Aug 30, 2022 •
edited
Loading

Snaps to vscode#158315 by introducing a 2px border radius for the basic button component.

Note that it does not update the core token since that applies to more components beyond the button.

hawkticehurst
hawkticehurst approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@hawkticehurst hawkticehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

One thing to address is that the cornerRadius import is no longer being used so if you can remove that that would be great.

@daviddossett daviddossett merged commit 6fc339c into microsoft:main Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@hawkticehurst hawkticehurst hawkticehurst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daviddossett @hawkticehurst