Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check lowercase value on validExtensions #158319

Merged
merged 2 commits into from Aug 17, 2022
Merged

check lowercase value on validExtensions #158319

merged 2 commits into from Aug 17, 2022

Conversation

MaddyDev
Copy link
Contributor

@MaddyDev MaddyDev commented Aug 16, 2022 •
edited

Update the valid extension check to check against the lowercased values so images with capital extensions will also be rendered.

PR to address #158318

@meganrogge meganrogge assigned bpasero and unassigned meganrogge Aug 16, 2022
@bpasero bpasero added this to the August 2022 milestone Aug 17, 2022
bpasero
bpasero approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bpasero bpasero enabled auto-merge (squash) August 17, 2022 05:49
@bpasero bpasero merged commit bf51460 into microsoft:main Aug 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
August 2022
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MaddyDev @bpasero @meganrogge @VSCodeTriageBot