Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text in terminal has a visible baseline #158326

Closed
roblourens opened this issue Aug 16, 2022 · 9 comments · Fixed by #158630
Closed

Text in terminal has a visible baseline #158326

roblourens opened this issue Aug 16, 2022 · 9 comments · Fixed by #158630
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
August 2022

Comments

@roblourens
Copy link
Member

I've been seeing a lot of this since last week. I assume there's another issue for it but I don't see it
image
@roblourens
Copy link
Member Author

Recording 2022-08-16 at 16 27 14

Is this related? It keeps happening too

@Tyriar
Copy link
Member

Tyriar commented Aug 17, 2022

@roblourens that's because of our improved underlining, it doesn't look at good on your font because it's drawn a bit lower in the cell though. What font is it?

@Tyriar Tyriar added terminal-rendering bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Aug 17, 2022
@Tyriar Tyriar added this to the August 2022 milestone Aug 17, 2022
@roblourens
Copy link
Member Author

Cascadia Code

@roblourens
Copy link
Member Author

With the default, still a bit off
image

@Tyriar
Copy link
Member

Tyriar commented Aug 18, 2022

@roblourens thanks, that's macOS with zoom level 0?

@roblourens
Copy link
Member Author

Yeah

@Tyriar
Copy link
Member

Tyriar commented Aug 19, 2022

Default font on macOS (Menlo):

Screen Shot 2022-08-19 at 1 04 24 pm

@Tyriar
Copy link
Member

Tyriar commented Aug 19, 2022 •
edited

Font size 12:
Screen Shot 2022-08-19 at 1 06 40 pm

Font size 14:
Screen Shot 2022-08-19 at 1 07 06 pm

Font size 16:
Screen Shot 2022-08-19 at 1 07 52 pm

@Tyriar
Copy link
Member

Tyriar commented Aug 19, 2022

Can also happen on dpr 1 (Windows 11, Hack):

image

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 19, 2022
@Tyriar
Move webgl underline rendering down
79d4789 
See microsoft/vscode#158326
@Tyriar Tyriar mentioned this issue Aug 19, 2022
Merged
Tyriar added a commit that referenced this issue Aug 19, 2022
@Tyriar
Update xterm
1ecc2a8 
Fixes #158326
@Tyriar Tyriar mentioned this issue Aug 19, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 19, 2022
@roblourens roblourens added the verified Verification succeeded label Aug 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
Update xterm
0d72691 
Fixes microsoft#158326
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

Update xterm microsoft/vscode
3 participants
@roblourens @Tyriar @VSCodeTriageBot