Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more refined code action group separators #158515

Closed
justschen opened this issue Aug 18, 2022 · 2 comments · Fixed by #161134
Closed

Add more refined code action group separators #158515

justschen opened this issue Aug 18, 2022 · 2 comments · Fixed by #161134
Assignees
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded

Comments

@justschen
Copy link
Contributor

Looking into adding additional separators that are more common, so that all the additional refactorings are not just clumped under More Acitons

From comment:

I was wondering if you would consider adding 2 code action classes that are I think quite common:

  • refactor.inline (Inline)
  • refactor.move (Move)

This would be super valuable for the extension that I'm developing (P42 JavaScript Assistant), but I think also for other extensions. Afaik the TS language server also has refactor.move actions for example.

Originally posted by @lgrammel in #132109 (comment)

@justschen justschen self-assigned this Aug 18, 2022
@justschen justschen added the editor-code-actions Editor inplace actions (Ctrl + .) label Aug 18, 2022
@justschen justschen added this to the August 2022 milestone Aug 19, 2022
@CsCherrYY
Copy link
Contributor

Hey @justschen , the new code action widget looks great, and I really like the new code action grouping, I'm wondering if we can define custom code action groups besides the pre-defined groups.

image

you can see the java extension contributes a code action (in the light bulb) named "add Javadoc" and it's now under "More Actions..." menu. If we can define a new group like "Sources" via extension, it would be great and more clear that we can put this action in that group.

@mjbvz mjbvz modified the milestones: August 2022, September 2022 Aug 25, 2022
@mjbvz mjbvz assigned mjbvz and unassigned justschen Aug 25, 2022
@matthewjamesadam
Copy link
Contributor

We have an extension that publishes some code actions. With the latest VSCode, our actions are grouped under 'More Actions...' which in our context is not ideal. We would prefer to be able to define our own grouping for our actions (in extension parlance, I think this means to be able to create our own CodeActionKind). Thanks!

@mjbvz mjbvz modified the milestones: September 2022, Backlog Sep 8, 2022
@mjbvz mjbvz added the feature-request Request for new features or functionality label Sep 9, 2022
@mjbvz mjbvz modified the milestones: Backlog, September 2022 Sep 16, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Sep 16, 2022
Fixes microsoft#158515

Also aligns the icon to be more consistent with how they are used:

- Surround with snippets use snippet icon
- All refactorings use the wrench icon
- Remove custom color which was added to some refactorings but not others
mjbvz added a commit that referenced this issue Sep 16, 2022
Fixes #158515

Also aligns the icon to be more consistent with how they are used:

- Surround with snippets use snippet icon
- All refactorings use the wrench icon
- Remove custom color which was added to some refactorings but not others
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 16, 2022
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Sep 26, 2022
@lramos15 lramos15 added the verified Verification succeeded label Sep 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants