Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support socks5h:// in http.proxy. #158669

Closed
Tracked by #200459
jmjoy opened this issue Aug 20, 2022 · 3 comments
Closed
Tracked by #200459

Support socks5h:// in http.proxy. #158669

jmjoy opened this issue Aug 20, 2022 · 3 comments
Assignees
@chrmarti
Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality proxy Issues regarding network proxies
Milestone
Backlog

Comments

@jmjoy
Copy link

jmjoy commented Aug 20, 2022

The environment variable http_proxy starts with socks5h:// means resolve domain via proxy server.

But the setting http.proxy is only allow socks5:// (socks5h:// doesn't match the regex).

When http_proxy is setted starts with socks5h://, the network in vscode is not work.

Maybe support it?
@joyceerhl joyceerhl assigned joaomoreno and unassigned joyceerhl Aug 20, 2022
@joaomoreno joaomoreno assigned chrmarti and unassigned joaomoreno Aug 22, 2022
@chrmarti chrmarti added feature-request Request for new features or functionality proxy Issues regarding network proxies labels Dec 12, 2022
@chrmarti chrmarti added this to the Backlog milestone Dec 12, 2022
@sky5454
Copy link

sky5454 commented Jul 7, 2023

really important, dns hostname lookup through the socks5 proxy.

chrmarti added a commit to microsoft/vscode-proxy-agent that referenced this issue Jul 7, 2023
@chrmarti
Handle additional socks schemes (microsoft/vscode#158669)
7ec29aa
@chrmarti chrmarti mentioned this issue Jul 7, 2023
Merged
chrmarti added a commit to microsoft/vscode-proxy-agent that referenced this issue Jul 7, 2023
@chrmarti
Handle additional socks schemes (microsoft/vscode#158669)
2292b05
@chrmarti chrmarti mentioned this issue Jul 7, 2023
Merged
chrmarti added a commit that referenced this issue Jul 7, 2023
@chrmarti
Allow additional socks schemes (#158669)
c689184
chrmarti added a commit that referenced this issue Jul 7, 2023
@chrmarti
Allow additional socks schemes (#158669)
4c1e4bb
@chrmarti
Copy link
Contributor

This is in the latest VS Code Insiders now (part of @vscode/proxy-agent 0.15.0). Would be great if you could give it a try and let us know if it works for you. Thanks!

@chrmarti chrmarti added the author-verification-requested Issues potentially verifiable by issue author label Jul 12, 2023
@gerroon
Copy link

gerroon commented Dec 9, 2023

This is in the latest VS Code Insiders now (part of @vscode/proxy-agent 0.15.0). Would be great if you could give it a try and let us know if it works for you. Thanks!

How do we use it? I need to use socks proxy in Code.

@ksh5a ksh5a mentioned this issue Dec 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrmarti chrmarti

Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality proxy Issues regarding network proxies
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@joaomoreno @gerroon @jmjoy @chrmarti @sky5454 @joyceerhl @VSCodeTriageBot