New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support batch range formatting #158776
Comments
This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
Would the team be open to PR for this change? I'm happy to provide one. |
To give additional context, we've had user reports like this:
When a file has lots of modified chunks, we see lots of round-trips to the server. Batching the requests can provide a very important performance improvement in some cases. |
This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
feedback from API sync, have explicit optional function
|
fyi @dbaeumer this is done and LSP adoption is welcome |
@c-claeys already provided a PR for LSP. https://insiders.vscode.dev/github/microsoft/vscode-languageserver-node/blob/main/protocol/src/common/protocol.ts#L3515 |
To verify:
|
With
Editor: Format On Save Mode
set tomodifications
, VSCode will sequentially send requests to itsrangeFormatting
provider(s). It'd be nice if the whole list of ranges could be sent at once instead of sequentially, allowing the formatter to handle this batch as it sees fit. This could be achieved by modifyingregisterDocumentRangeFormattingEditProvider
to take an additional optional metadata parameter that the provider can use to express support for thismultiRange
mode.The text was updated successfully, but these errors were encountered: