Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Terminal inactive selection background #158828

Closed
3 tasks done
Tyriar opened this issue Aug 22, 2022 · 2 comments
Closed
3 tasks done

Test: Terminal inactive selection background #158828

Tyriar opened this issue Aug 22, 2022 · 2 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 22, 2022

Refs: #156985

Complexity: 2

Authors: @meganrogge @Tyriar

Create Issue


An inaction (unfocused) selection background color is now supported in the terminal, similar to the editor. Please test:

  • The feature works with all values of terminal.integrated.gpuAcceleration
  • The selection background color works as expected (same as in the editor) on all built-in themes
  • Setting terminal.inactiveSelectionBackground in workbench.colorCustomizations works with both opaque (#rrggbb) and transparent (#rrggbbaa) colors
@Tyriar Tyriar added this to the August 2022 milestone Aug 22, 2022
@alexr00
Copy link
Member

alexr00 commented Aug 23, 2022

Interestingly, my terminal selection is lost when I change themes. Not sure if that's a bug though.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 23, 2022

@alexr00 good polish change we could make 👍

@lszomoru lszomoru assigned dbaeumer and unassigned amunger Aug 25, 2022
@dbaeumer dbaeumer removed their assignment Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants