Should the default inactive terminal selection background be the same one as used by the editor

[isidorn]

Testing #158828

I think currently the default terminal and the editor selection colours are different.
Should we use the same default inactive selection background both in the editor and the terminal (for consistency and less different colours on the screen)?

[Tyriar]

That's the intention, they are derived by the terminal.selection key and not the editor one though so it might depend on the theme.

If you're not seeing #158896, was this using any particular theme we ship?

[isidorn]

In the default light theme they look pretty different to me (editor is greyish, terminal is blueish).
#158896 is unrelated to this, I have changed the gpu acceleration setting back to auto.

Feel free to close if by design. I thought that editor and terminal selection colour should align more, but I understand that they use a different background colour so that might not always work.

[Tyriar]

Ah, this is because editor.inactiveSelectionBackground is defined in Light+, the terminal one is derived from terminal.selectionBackground, not editor.inactiveSelectionBackground.

@daviddossett want to take this one to do a once over of all the themes to make the inactive selection colors consistent?

[daviddossett]

Light (Visual Studio) defines "editor.inactiveSelectionBackground": "#E5EBF1" which is picked up by Light+. I think inheriting editor.inactiveSelectionBackground for the terminal color as we do for regular selection via terminal.selectionBackground makes the most sense here. We're copying over the transparency rules already anyway.

[daviddossett]

Ended up just explictly defining terminal.inactiveSelectionBackground for any default theme that specifies editor.inactiveSelectionBackground to keep them in sync.