Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previewing renames with Shift+Enter seems broken #160296

Closed
jrieken opened this issue Sep 7, 2022 · 1 comment · Fixed by #160329
Closed

Previewing renames with Shift+Enter seems broken #160296

jrieken opened this issue Sep 7, 2022 · 1 comment · Fixed by #160329
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken rename verified Verification succeeded
Milestone
September 2022

Comments

@jrieken
Copy link
Member

jrieken commented Sep 7, 2022

  • F2 to rename
  • type a new name
  • hit Shift+Enter to rename with preview
  • 🐛 no preview
@jrieken jrieken self-assigned this Sep 7, 2022
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug rename regression Something that used to work is now broken labels Sep 7, 2022
@jrieken jrieken added this to the September 2022 milestone Sep 7, 2022
@jrieken
Copy link
Member Author

jrieken commented Sep 7, 2022

This is a regression from the context key eventing change...

jrieken added a commit that referenced this issue Sep 7, 2022
@jrieken
Undo context key service changes because of regression,
76456b5 
This reverts commit 77a89ef.

This fixes #160296
@jrieken jrieken mentioned this issue Sep 7, 2022
Merged
jrieken added a commit that referenced this issue Sep 8, 2022
@jrieken
Undo context key service changes because of regression, (#160329)
bcf14fe 
* Undo context key service changes because of regression,

This reverts commit 77a89ef.

This fixes #160296

* fix compile

* next try...
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 8, 2022
@mjbvz mjbvz added the verified Verification succeeded label Sep 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken rename verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

Undo context key service changes because of regression, microsoft/vscode
3 participants
@jrieken @mjbvz @VSCodeTriageBot