Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide UX affordances for turning on Edit Sessions #160364

Merged
merged 6 commits into from Sep 8, 2022
Merged

Provide UX affordances for turning on Edit Sessions #160364

merged 6 commits into from Sep 8, 2022

Conversation

joyceerhl
Copy link
Contributor

@joyceerhl joyceerhl commented Sep 7, 2022 •
edited

This PR fixes #159078

  • When the user invokes Continue On, prompt to turn on Edit Sessions but offer an option to skip turning on Edit Sessions in the quickpick and a quickpick item button to configure always skipping Edit Sessions
  • Rename Continue Edit Session to Continue Working On
  • If the user doesn't have Edit Sessions turned on and they are going from web to desktop without having used Edit Sessions on desktop before, their current edit session will fail to resume when using Continue On. To mitigate this, increment the global activity badge when the user hasn't turned on Edit Sessions. Initial run of disabling and enabling activity bar badges #158781 should allow users to disable this badge if desired

@joyceerhl joyceerhl self-assigned this Sep 7, 2022
@joyceerhl joyceerhl marked this pull request as ready for review September 7, 2022 23:44
@VSCodeTriageBot VSCodeTriageBot added this to the September 2022 milestone Sep 7, 2022
@joyceerhl joyceerhl merged commit e41b3a8 into main Sep 8, 2022
@joyceerhl joyceerhl deleted the dev/joyceerhl/polish-auth branch September 8, 2022 09:17
@joyceerhl joyceerhl mentioned this pull request Sep 14, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@joyceerhl joyceerhl

Labels
None yet
Projects
None yet
Milestone
September 2022
Development

Successfully merging this pull request may close these issues.

Improve authentication story for edit sessions
3 participants
@joyceerhl @alexr00 @VSCodeTriageBot