Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to have checkAndCreateProfileFromCli in one place #160678

Closed
bpasero opened this issue Sep 12, 2022 · 0 comments
Closed

Consider to have checkAndCreateProfileFromCli in one place #160678

bpasero opened this issue Sep 12, 2022 · 0 comments
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Sep 12, 2022

#160643 will make IWindowsMainService.open async and I wonder if the call to checkAndCreateProfileFromCli should then move into the windows main service so that we consistently resolve the profile from CLI properly in all cases.

I think we only now had the call outside of windows main service because opening windows was not async until then.

const profile = await this.userDataProfilesMainService.checkAndCreateProfileFromCli(this.environmentMainService.args);

profile: await this.userDataProfilesMainService.checkAndCreateProfileFromCli(pargs)

const profile = await this.userDataProfilesMainService.checkAndCreateProfileFromCli(args);

@bpasero bpasero added the debt Code quality issues label Sep 12, 2022
@sandy081 sandy081 added this to the September 2022 milestone Sep 12, 2022
@sandy081 sandy081 modified the milestones: September 2022, October 2022 Sep 27, 2022
@sandy081 sandy081 modified the milestones: October 2022, November 2022 Oct 24, 2022
sandy081 added a commit that referenced this issue Nov 7, 2022
@sandy081 sandy081 mentioned this issue Nov 7, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

No branches or pull requests

3 participants