Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot add a decoration for a command undefined with no marker #160839

Closed
meganrogge opened this issue Sep 13, 2022 · 1 comment · Fixed by #160840
Closed

cannot add a decoration for a command undefined with no marker #160839

meganrogge opened this issue Sep 13, 2022 · 1 comment · Fixed by #160840
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
September 2022

Comments

@meganrogge
Copy link
Contributor 

 ERR cannot add a decoration for a command undefined with no marker: Error: cannot add a decoration for a command undefined with no marker
    at c.registerCommandDecoration (vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1934:14829)
    at c.registerMarkDecoration (vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1934:11613)
    at vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1934:11322
    at p.invoke (vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:83:145)
    at l.deliver (vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:83:2266)
    at d.fire (vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:83:1844)
    at m.addMark (vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:656:1889)
    at Ui.addBufferMarker (vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3081:6583)
    at vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1697:37176
    at p.invoke (vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:83:145)
    at l.deliver (vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:83:2266)
    at d.fire (vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:83:1844)
    at i.tryFinish (vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1697:34851)
    at i.processLineInternal (vscode-file://vscode-app/Users/meganrogge/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1697:33723)
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. tasks Task system issues labels Sep 13, 2022
@meganrogge meganrogge added this to the September 2022 milestone Sep 13, 2022
meganrogge added a commit that referenced this issue Sep 13, 2022
@meganrogge
fix #160839
7482dbe
@meganrogge meganrogge mentioned this issue Sep 13, 2022
Merged
@meganrogge
Copy link
Contributor Author

repro is to run the VS Code build task and open the dev tools console. You shouldn't see this error

meganrogge added a commit that referenced this issue Sep 14, 2022
@meganrogge
pass mark properties in to create decoration (#160840)
41aacfa 
fix #160839
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 14, 2022
@IanMatthewHuff IanMatthewHuff added the verified Verification succeeded label Sep 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

pass mark properties in to create decoration microsoft/vscode
4 participants
@IanMatthewHuff @Tyriar @meganrogge @VSCodeTriageBot