Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook diff: no way to navigate between changes #161921

Closed
isidorn opened this issue Sep 27, 2022 · 1 comment
Closed

Notebook diff: no way to navigate between changes #161921

isidorn opened this issue Sep 27, 2022 · 1 comment
Assignees
@rebornix
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook-diff verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2023

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 27, 2022

Testing #161861

Ideally there would be commands to navigate between changes. And they might deserve an action in the diff title bar.
Same as the editor diff experience.

Screenshot 2022-09-27 at 11 02 35
@rebornix rebornix added feature-request Request for new features or functionality notebook-diff labels Oct 21, 2022
rebornix added a commit that referenced this issue Dec 28, 2022
@rebornix
Merge pull request #170172 from microsoft/rebornix/thoughtless-yak
ee77088 
Fix #161921. Add diff navigvation.
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 28, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the January 2023 milestone Dec 28, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 3, 2023
@rebornix rebornix added the verification-needed Verification of issue is requested label Jan 24, 2023
@joyceerhl joyceerhl added the verified Verification succeeded label Jan 25, 2023
@joyceerhl
Copy link
Contributor

Why is f1:false for these commands? I would expect them to be available from the command palette, since in a regular text editor Show Previous Change and Show Next Change both appear.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook-diff verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

No branches or pull requests
4 participants
@rebornix @isidorn @joyceerhl @VSCodeTriageBot