Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git similar command doesn't work on windows\ #161997

Closed
meganrogge opened this issue Sep 27, 2022 · 7 comments · Fixed by #162057, #162189 or #162327
Closed

git similar command doesn't work on windows\ #161997

meganrogge opened this issue Sep 27, 2022 · 7 comments · Fixed by #162057, #162189 or #162327
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-quick-fix verified Verification succeeded windows VS Code on Windows issues
Milestone
September 2022

Comments

@meganrogge
Copy link
Contributor 

    > @connor4312 what input are you trying?

we have an issue tracking this that hasn't yet been completed #161595 (comment)

I don't think that's the same issue.

Here's a recording:

Kapture.2022-09-27.at.17.32.05.mp4

Originally posted by @connor4312 in #161846 (comment)
@meganrogge
Copy link
Contributor Author

@connor4312 had you cleared the terminal?

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-quick-fix labels Sep 27, 2022
@meganrogge meganrogge added the windows VS Code on Windows issues label Sep 27, 2022
@meganrogge meganrogge added this to the September 2022 milestone Sep 27, 2022
@meganrogge
Copy link
Contributor Author

meganrogge commented Sep 27, 2022 •
edited

can reproduce after clearing the terminal on windows via Terminal: clear

EDIT: only works when the lightbulb is on the very bottom of the terminal - we have the wrong line demand it seems / offset

@meganrogge meganrogge changed the title git similar command doesn't work on windows sometimes git similar command doesn't work on windows after clear Sep 27, 2022
@meganrogge
Copy link
Contributor Author

here's the only place it works for me on windows

light

@meganrogge
Copy link
Contributor Author

meganrogge commented Sep 27, 2022 •
edited

probably something wrong/unexpected happening with the constraints
Screen Shot 2022-09-27 at 8 52 48 AM

@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2022

@meganrogge the problem is the lightbulb doesn't show? What's the problem there?

meganrogge added a commit that referenced this issue Sep 27, 2022
@meganrogge
fix #161997
7208804
@meganrogge meganrogge mentioned this issue Sep 27, 2022
Merged
@meganrogge meganrogge changed the title git similar command doesn't work on windows after clear git similar command doesn't work on windows\ Sep 27, 2022
meganrogge added a commit that referenced this issue Sep 27, 2022
@meganrogge
tweak regex for git similar command (#162057)
8b4a451 
fix #161997
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 27, 2022
@connor4312
Copy link
Member

I had cleared that terminal, but this reproduces for me on a fresh terminal without clearing

@Tyriar
Copy link
Member

Tyriar commented Sep 28, 2022

Ah, I broke this for all platforms in #162083

@Tyriar Tyriar reopened this Sep 28, 2022
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Sep 28, 2022
@Tyriar Tyriar mentioned this issue Sep 28, 2022
Merged
Tyriar added a commit that referenced this issue Sep 28, 2022
@Tyriar
Allow opt-in multi-line quick fixes
ac3707a 
Fixes #161997
meganrogge added a commit that referenced this issue Sep 28, 2022
@Tyriar @meganrogge
Allow opt-in multi-line quick fixes (#162189)
0c22a33 
Fixes #161997

Co-authored-by: meganrogge <merogge@microsoft.com>
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Sep 28, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 29, 2022
@Tyriar Tyriar reopened this Sep 29, 2022
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Sep 29, 2022
Tyriar added a commit that referenced this issue Sep 29, 2022
@Tyriar
Allow opt-in multi-line quick fixes
79bacef 
Fixes #161997
@Tyriar Tyriar mentioned this issue Sep 29, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 29, 2022
@meganrogge meganrogge added the verified Verification succeeded label Sep 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-quick-fix verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
September 2022
4 participants
@Tyriar @connor4312 @meganrogge @VSCodeTriageBot