Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Bracket higlight feature on scroll bar #16228

Closed
soljohnston777 opened this issue Nov 29, 2016 · 8 comments
Closed

Add a Bracket higlight feature on scroll bar #16228

soljohnston777 opened this issue Nov 29, 2016 · 8 comments
Assignees
@alexdima
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2018

Comments

@soljohnston777
Copy link

When you select an object/variable, etc it shows it highlighted on the scroll bar. Could you also do this for brackets { } ? That way you know where a bracket opens and closes. I us brackets in PHP, javascript, JQuery, CSS, etc.
@chrmarti chrmarti added the feature-request Request for new features or functionality label Nov 29, 2016
@alexdima alexdima added this to the Backlog milestone Nov 30, 2016
@alexdima alexdima removed their assignment Nov 30, 2016
@alexdima alexdima added the good first issue Issues identified as good for first-time contributors label Nov 23, 2017
@danrpinho
Copy link

Hey, I'd like to take a look at solving this. Do you have any ideas on where I should get started?

@alexdima
Copy link
Member

_DECORATION_OPTIONS in bracketMatching.ts can use the overviewRuler option to render something in the overview ruler similar to how overviewRuler is used in the decoration options of wordHighlighter.ts -> _WRITE_OPTIONS.

The color used should also be externalized such that themese can customize it (again similar to wordHighlighter.ts).

@danrpinho
Copy link

Thanks, I'll get on it!

@danrpinho danrpinho mentioned this issue Dec 3, 2017
Merged
@ntnbst
Copy link

ntnbst commented Dec 30, 2017

has this feature added ??

@danrpinho
Copy link

@ntnbst I submitted a working pull request almost a month ago, but it hasn't been either accepted or declined.

@alexdima alexdima self-assigned this Jan 24, 2018
@alexdima alexdima modified the milestones: Backlog, January 2018 Jan 24, 2018
@alexdima
Copy link
Member

Closed via #39501

alexdima added a commit that referenced this issue Jan 24, 2018
@alexdima
Merge pull request #39501 from danrpinho/highlight_brackets_scrollbar
ad6067a 
Adds bracket highlighting in scrollbar, fixes issue #16228
@soljohnston777
Copy link
Author

Is in the latest release? And how can you active it?

@alexdima
Copy link
Member

It is in today's Insiders Build Channel. You place the cursor near a bracket.

@alexdima alexdima added the verification-needed Verification of issue is requested label Jan 30, 2018
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Jan 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
6 participants
@alexdima @chrmarti @ramya-rao-a @soljohnston777 @ntnbst @danrpinho