Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve batching between search process and frontend #16284

Closed
roblourens opened this issue Nov 30, 2016 · 0 comments · Fixed by #16333
Closed

Improve batching between search process and frontend #16284

roblourens opened this issue Nov 30, 2016 · 0 comments · Fixed by #16333
Assignees
@roblourens
Labels
search Search widget and operation issues
Milestone
November 2016

Comments

@roblourens
Copy link
Member

Fork of #15384

The time from starting the search to finding a match is very short, but then we sit on that match for 100+ seconds, because we don't send results to the frontend until we've filled a batch of 512. Since there are fewer than a full batch of results, nothing is visible until the search is over. So we could increase the perceived performance quite a lot by adding a timeout to send intermediate results over if the batch doesn't fill up.
@roblourens roblourens self-assigned this Nov 30, 2016
@roblourens roblourens added this to the November 2016 milestone Nov 30, 2016
@roblourens roblourens added the search Search widget and operation issues label Nov 30, 2016
@roblourens roblourens mentioned this issue Nov 30, 2016
Merged
roblourens added a commit to roblourens/vscode that referenced this issue Dec 1, 2016
@roblourens
Fix microsoft#16284 - smarter batching to get results to the frontend…
3984148 
… faster
roblourens added a commit that referenced this issue Dec 1, 2016
@roblourens
Fix #16284 - smarter batching to get results to the frontend faster
fb8e08a
@roblourens roblourens mentioned this issue Dec 1, 2016
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
search Search widget and operation issues
Projects
None yet
Milestone
November 2016
Development

Successfully merging a pull request may close this issue.

Smarter search batching microsoft/vscode
1 participant
@roblourens