Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox is hard to see in dark mode on selected file change node in tree view #163881

Closed
joyceerhl opened this issue Oct 14, 2022 · 1 comment · Fixed by #165556
Closed

Checkbox is hard to see in dark mode on selected file change node in tree view #163881

joyceerhl opened this issue Oct 14, 2022 · 1 comment · Fixed by #165556
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Milestone
November 2022

Comments

@joyceerhl
Copy link
Contributor

With default Dark+ theme:

image
@alexr00 alexr00 transferred this issue from microsoft/vscode-pull-request-github Oct 17, 2022
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues labels Oct 17, 2022
@alexr00 alexr00 added this to the October 2022 milestone Oct 17, 2022
@cooleditphoto
Copy link

Hi, I want to work on this, and I think src/vs/workbench/browser/parts/views/treeView.ts is the file that needs to be changed, could you please advise on this? Thanks! @alexr00

@alexr00 alexr00 modified the milestones: October 2022, November 2022 Oct 24, 2022
@alexr00 alexr00 mentioned this issue Nov 4, 2022
Merged
alexr00 added a commit that referenced this issue Nov 4, 2022
@alexr00
Checkbox is hard to see in dark mode on selected file change node in …
dc33130 
…tree view

Fixes #163881
alexr00 added a commit that referenced this issue Nov 4, 2022
@alexr00
Checkbox is hard to see in dark mode on selected file change node in …
9b6017a 
…tree view (#165556)

Fixes #163881
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 4, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

Checkbox is hard to see in dark mode on selected file change node in tree view microsoft/vscode
4 participants
@cooleditphoto @joyceerhl @alexr00 @VSCodeTriageBot