"Add to Workspace Recommendations" works incorrectly, when extension id has upper case.

[lclancey]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version:
  1.72.2
• OS Version:
  MacOS Monterey 12.3.1

Steps to Reproduce:

1. Open any directory or workspace, empty directory in the video below for example.
2. In Extensions tab, search "volar", then add first two extensions, Vue Language Features(Volar) and TypeScript Vue Plugin(Volar) into workspace recommendations.
3. Bug: Every time you try to add one of these two extensions, the newly added extension id in ./vscode/extensions.json is a string start with a upper case like "Vue.xxx", and the rest of others will change to all lower case string like "volar.xxx", this makes further "Add to Workspace Recommendations" oprations work incorrectly.

2022-10-24.20.48.27.mov

My guessing:
The function getRecommendations and getUnwantedRecommendations returns an array of lowercase strings,

vscode/src/vs/workbench/services/extensionRecommendations/common/workspaceExtensionsConfig.ts

Lines 82 to 90 in 7bd27b4

	async getRecommendations(): Promise<string[]> {
	const configs = await this.getExtensionsConfigs();
	return distinct(flatten(configs.map(c => c.recommendations ? c.recommendations.map(c => c.toLowerCase()) : [])));
	}
	async getUnwantedRecommendations(): Promise<string[]> {
	const configs = await this.getExtensionsConfigs();
	return distinct(flatten(configs.map(c => c.unwantedRecommendations ? c.unwantedRecommendations.map(c => c.toLowerCase()) : [])));
	}

however those adding or removing functions only push the raw extensionId to config file, which causes this bug when the raw extensionId has upper case.

vscode/src/vs/workbench/services/extensionRecommendations/common/workspaceExtensionsConfig.ts

Lines 144 to 158 in 7bd27b4

	private async addOrRemoveWorkspaceFolderRecommendation(extensionId: string, workspaceFolder: IWorkspaceFolder, extensionsConfigContent: IExtensionsConfigContent, add: boolean): Promise<void> {
	const values: IJSONValue[] = [];
	if (add) {
	values.push({ path: ['recommendations'], value: [...extensionsConfigContent.recommendations || [], extensionId] });
	if (extensionsConfigContent.unwantedRecommendations && extensionsConfigContent.unwantedRecommendations.some(e => e === extensionId)) {
	values.push({ path: ['unwantedRecommendations'], value: extensionsConfigContent.unwantedRecommendations.filter(e => e !== extensionId) });
	}
	} else if (extensionsConfigContent.recommendations) {
	values.push({ path: ['recommendations'], value: extensionsConfigContent.recommendations.filter(e => e !== extensionId) });
	}
	if (values.length) {
	return this.jsonEditingService.write(workspaceFolder.toResource(EXTENSIONS_CONFIG), values, true);
	}
	}

[sandy081]

I am not sure what the bug is here? Since extension ids are case insensitive, we handle them correctly while reading or writing. Can you please let us know what feature is not working?

[lclancey]

I am not sure what the bug is here? Since extension ids are case insensitive, we handle them correctly while reading or writing. Can you please let us know what feature is not working?

Well, a simple description: you can click Add to Workspace Recommendations twice when adding vue.volar...the first time it will add "Vue.volar" string and second time "vue.volar".

Screen.Recording.2022-10-24.at.11.59.16.PM.mov

[sandy081]

Got it. Thanks for providing info.