Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wording in "update Markdown Links" prompt #164556

Closed
weinand opened this issue Oct 25, 2022 · 0 comments · Fixed by #164764
Closed

Wording in "update Markdown Links" prompt #164556

weinand opened this issue Oct 25, 2022 · 0 comments · Fixed by #164764
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
October 2022

Comments

@weinand
Copy link
Contributor

weinand commented Oct 25, 2022 •
edited

Testing #164522

The "Always..." and "Never..." button labels are very long and make the dialog look ugly unbalanced.

CleanShot 2022-10-25 at 12 06 52@2x

Is it really necessary to duplicate the "automatically update Markdown Links" in two cases ("Always", "Never") but omit it in the other two ("Yes", "No")?

For me just the labels "Always" and "Never" would work.

A nit: capitalisation of "Links" is inconsistent.
@mjbvz mjbvz mentioned this issue Oct 25, 2022
Closed
@mjbvz mjbvz added this to the October 2022 milestone Oct 26, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Oct 26, 2022
@mjbvz
Shorten markdown link button titles
e670974 
Fixes microsoft#164556
@mjbvz mjbvz mentioned this issue Oct 26, 2022
Merged
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Oct 26, 2022
mjbvz added a commit that referenced this issue Oct 26, 2022
@mjbvz
Shorten markdown link button titles (#164764)
7060fb8 
Fixes #164556
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 26, 2022
formigoni pushed a commit to formigoni/vscode that referenced this issue Oct 27, 2022
@mjbvz @formigoni
Shorten markdown link button titles (microsoft#164764)
3428b6d 
Fixes microsoft#164556
@joyceerhl joyceerhl added the verified Verification succeeded label Oct 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
October 2022
Development

Successfully merging a pull request may close this issue.

Shorten markdown link button titles mjbvz/vscode
4 participants
@weinand @mjbvz @joyceerhl @VSCodeTriageBot